Giter Club home page Giter Club logo

Comments (5)

simonster avatar simonster commented on June 12, 2024

If the two arrays are different sizes, I guess we return false even if they contain NAs?

from dataarrays.jl.

johnmyleswhite avatar johnmyleswhite commented on June 12, 2024

All of this sounds reasonable to me. Might be interesting to hear @StefanKarpinski's view on this.

from dataarrays.jl.

StefanKarpinski avatar StefanKarpinski commented on June 12, 2024

Both of @simonster's suggestions seem reasonable. DataFrames has already modified the "contract" of == to include returning NA as a viable option, so this seems like the logical extension of that.

from dataarrays.jl.

simonster avatar simonster commented on June 12, 2024

Thinking this through a little more, maybe we should return false if any non-NA values are unequal (the arrays would be unequal even if there weren't missing data), NA if all non-NA values are equal but NAs are present (we can't tell if the arrays are equal because of the missing data), or true if all values are equal and there are no NAs.

from dataarrays.jl.

johnmyleswhite avatar johnmyleswhite commented on June 12, 2024

That makes sense and would be consistent with interpreting x == y as equivalent to all(x .== y) under the current Boolean rules for NA.

from dataarrays.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.