Giter Club home page Giter Club logo

Comments (6)

nalimilan avatar nalimilan commented on June 12, 2024

Damn. In the discussion I started on julia-stats a while ago [1], @StefanKarpinski said that he thought [1,NA,2] should be possible at some point, using later-stage functions. Since this means @data wouldn't be needed anymore, I'd say just ignore this for now, and let people use the data() function.

1: https://groups.google.com/d/topic/julia-stats/1CYmgu1Lye0/discussion

from dataarrays.jl.

johnmyleswhite avatar johnmyleswhite commented on June 12, 2024

I hope staged functions are sufficient. I am going to ignore this for now since I don't see a way forward without new tools in Base.

from dataarrays.jl.

simonster avatar simonster commented on June 12, 2024

The right way to do this is to implement datahcat, datavcat, and datahvcat and make the data and pdata macros call these. I have this working, but 1) if we care about accurate type inference, it's a decent amount of code copy/pasted from Base with a few lines changed and 2) it's not currently working because of a bug in setindex!.

from dataarrays.jl.

johnmyleswhite avatar johnmyleswhite commented on June 12, 2024

Oh great. I had naively assumed the *cat functions were builtins.

So much of our codebase is basically copy/pasted from other places that I've got no opposition to doing it again.

What's the bug in setindex!?

from dataarrays.jl.

simonster avatar simonster commented on June 12, 2024

The bug is that setting a portion of a DataArray to be another DataArray fails if the latter has NAs. #62 has an easy fix that would unfortunately create a bunch of ambiguity warnings if applied to master, but it isn't the complete fix; we should also handle setting a portion of a DataArray to be an arbitrary AbstractDataArray.

from dataarrays.jl.

simonster avatar simonster commented on June 12, 2024

(And after that change, my tests are still failing, now because of JuliaLang/julia#5448.)

from dataarrays.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.