Remove DataVector[1] hack; use a @data macro about dataarrays.jl HOT 5 CLOSED

As of d732800, I've implemented the @data and @pdata macros.

@HarlanH, @tshort: If you're ok with this change, I'll remove the DataVector[1, NA, 3] constructor in the next commit. I think the new macros are much superior: they use fewer characters and offer more functionality.

from dataarrays.jl.

Sounds good.

On Wed, Nov 13, 2013 at 11:21 PM, John Myles White <[email protected]

wrote:

As of d732800d732800,
I've implemented the @DaTa and @pdata macros.

@HarlanH https://github.com/HarlanH, @tshort https://github.com/tshort:
If you're ok with this change, I'll remove the DataVector[1, NA, 3]constructor in the next commit. I think the new macros are much superior:
they use fewer characters and offer more functionality.

—
Reply to this email directly or view it on GitHubhttps://github.com//issues/12#issuecomment-28458478
.

from dataarrays.jl.

+1. I like this approach.

The tests could use some cases where the types are mixed, like @data ["x", 1, 1.23, NA].

from dataarrays.jl.

Added two of those in fe0c0cc

Still need a lot more tests, which is why I started #15. As macros, this approach faces a lot of complications -- accessing variables in literals being the worst offender.

from dataarrays.jl.

Closed by af39464

from dataarrays.jl.