Comments (3)
What this issue is missing is an explanation of why these "long" files should be split. If there is content in one file that "obviously" is not strongly connected and thus there is a natural logical way to split the file, sure, why not.
But if the argument is just "the file is too long", I don't follow. What is "too long" about it, what problem does this cause? After this has been explained, we can debate it :-)
from julia.
None of those seem particularly egregious to me, as long as they contain all mostly related content. Those are not generally even the slow tests, and the files seem to me to have fairly consistent content. While we do split some files (such as codegen.cpp to multiple places such as ccall.cpp, cgutils.cpp, and intrinsics.cpp), I don't think we should commonly be adding #include <file.c>
-style
from julia.
These LOCs look quite ok to me. I agree that we should split if there are cases where that makes sense naturally. Otherwise, I propose we close this issue.
from julia.
Related Issues (20)
- ccall(:foo) doesn't pick up LD_PRELOAD overrides HOT 2
- specialize on exact Vararg number for all calls that are not via `_apply`?
- ERROR: LoadError: type CodeInfo has no field linetable HOT 1
- Segfault when using improperly defined struct HOT 6
- Regression on number of allocations in GC micro-benchmark
- ~10% memory regression in inference benchmarks due to 'ir: Fix incorrect renaming of phinode values (#52614)'
- Package precompilation shouldn't retry
- "Unreachable reached" bug during `Test.@inferred` on Julia 1.6.7 HOT 1
- Bracketed Paste Mode is not enabled on Windows
- Confusing error message when attempting to `setindex!` a `ScopedValue`
- Julia crashes when running a long task on a super computer that uses meta prorgamming and threads
- Weird Windows 11 failure / crash HOT 2
- Error: "attempt to send to unknown socket" after rmprocs
- 2x Regression in string join benchmark on NanoSoldier HOT 5
- Project precompilation fails on 1.11.0-alpha2 if Project.toml contains "name" but no UUID
- Incorrect Pkg commands result in "Unhandled Task ERROR:" HOT 1
- expose GMP bit-flipping operations (tstbit, combit, etcetera) HOT 2
- Segfault when LD_LIBRARY_PATH is set at something HOT 6
- RNA Extraction and RNA Purification Market Size, Growth Strategies, Competitive Landscape, Factor Analysis, 2035
- malformed profiling results, zero line numbers
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from julia.