Giter Club home page Giter Club logo

Comments (3)

fingolfin avatar fingolfin commented on June 15, 2024 5

What this issue is missing is an explanation of why these "long" files should be split. If there is content in one file that "obviously" is not strongly connected and thus there is a natural logical way to split the file, sure, why not.

But if the argument is just "the file is too long", I don't follow. What is "too long" about it, what problem does this cause? After this has been explained, we can debate it :-)

from julia.

vtjnash avatar vtjnash commented on June 15, 2024 1

None of those seem particularly egregious to me, as long as they contain all mostly related content. Those are not generally even the slow tests, and the files seem to me to have fairly consistent content. While we do split some files (such as codegen.cpp to multiple places such as ccall.cpp, cgutils.cpp, and intrinsics.cpp), I don't think we should commonly be adding #include <file.c>-style

from julia.

ViralBShah avatar ViralBShah commented on June 15, 2024

These LOCs look quite ok to me. I agree that we should split if there are cases where that makes sense naturally. Otherwise, I propose we close this issue.

from julia.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.