`imresize`/`imrotate` fixed point about imagetransformations.jl HOT 4 OPEN

Hi! I'm currently investigating your code and looking forward to contribute to it. But I can't understand, should those functions with FixedPointType as an argument always return OffsetArray? To me it feels like yes, otherwise it would be either a matrix with many empty values in it or with truncated values because of negative indices, except when that point is [1, 1]. Could you clear it out for me, am I wrong?

from imagetransformations.jl.

But I can't understand, should those functions with FixedPointType as an argument always return OffsetArray?

Yes, I think OffsetArray is the simplest model to reason about without loss of any information. People who are interested in 1-based array type can always combine the output OffsetArray with PaddedArray. For example, layer composition is a simple demo of such composition.

This is also why we have to set p::FixedPointType as a positional argument; if we set it as a keyword argument, which does not participate in method dispatch, there will be type instability between Array and OffsetArray.

from imagetransformations.jl.

Actually, I think the fixed point concept can be introduced to imrotate as well, in which case it's normally understood as the rotation center.

from imagetransformations.jl.

Yes, I think OffsetArray is the simplest model to reason about without loss of any information.

Alright, I got it. Should be easy enough.

Actually, I think the fixed point concept can be introduced to imrotate as well, in which case it's normally understood as the rotation center.

Yeah, it totally makes sense.

from imagetransformations.jl.