Tests on number of iterations are sensitive to randn about proximalalgorithms.jl HOT 4 CLOSED

@lostella I remember we decided to relax the tests on the number of iterations (I couldn't find the issue though).

Looks like they were not relaxed enough? The order look very similar, so it is definitively that:

[...]
  Expression: it_dys <= 1900
   Evaluated: 2363 <= 1900
[...]
  Expression: it_dys <= 2600
   Evaluated: 2877 <= 2600
[...]
  Expression: it_afba <= maxit
   Evaluated: 530 <= 500

I wonder if these tests could be replaced by something more robust...

from proximalalgorithms.jl.

@nantonel I think at this point it would be great to replace these tests with some fixed problem, instead of randomly generated...

from proximalalgorithms.jl.

I see that most calls to randn don't use a fixed random generator likerandn(rng, ComplexF32, (2, 3)).

That should avoid pasting numbers like in the LBFGS tests unless random generators are changed which I don't think happen very often.

from proximalalgorithms.jl.

@nantonel #38 fixes this

from proximalalgorithms.jl.