Tokenization of commas changed to `source.julia`, which affects Julia Color Themes about atom-language-julia HOT 8 CLOSED

@AquaPore Does the entry in your settings.json file look similar to the following?

    "editor.tokenColorCustomizations": {
        "[Julia (Monokai Classic)]": {
            "textMateRules" : [
                {
                    "scope": "source.julia punctuation.separator",
                    "settings": {
                        "foreground": "#EBE411"
                    }
                }
            ]
        }
    }

However, I don't think the new punctuation.separator scope has been released in the Julia extension yet.

from atom-language-julia.

Not sure, but it looks like the change might have been introduced in this PR: #268

from atom-language-julia.

Thanks Cameron, I tested this code into the setting .json and it only changed the ponctuation in the setting.json but not in the the JULIA code.

{ "scope": "punctuation.separator", "settings": { "foreground": "#AE81FF", "fontStyle": "italic" } },

from atom-language-julia.

Was this change intentional? If it was intentional, can we introduce a new scope for commas? In the VS Code Python extension, commas are scoped as punctuation.separator.

Yes, this change was intentional. Introducing an additional scope sounds reasonable.

from atom-language-julia.

Thanks Sebastien,

Will the effect take place in the next release of Julia Language Support in VSC?

Thanks for your help,
Joseph

from atom-language-julia.

@AquaPore I will also need to release a new version of Julia Color Themes that makes use of the new punctuation.separator scope that Sebastian introduced in #276. I will try to do that as soon as I can.

from atom-language-julia.

I tried with no sucess:
{ "scope": "punctuation.separator", "settings": { "foreground": "#ebe411", "fontStyle": "italic" } },

Joseph

from atom-language-julia.

No hurry take your time as it is not urgent

from atom-language-julia.