Comments (3)
Thanks again for opening this issue, and sorry for addressing it with such a delay.
Recently, #341 was merged and includes additions to extend Aqua-related checks. In the branch lb/iss339
I commented the lines related to the promote_rule
pointed out above, which seems unnecesary at least within the tests we have here (maybe they are needed in other packages that use TaylorSeries). The convert
method is needed, so I changed a bit its signature; all tests pass.
Can you test if that is enough to solve (or advance) with this issue?
In working on this, I noticed that, once IntervalArithmetic
is loaded (so the corresponding pkg-extension is included), Aqua detects the occurrence of some ambiguities:
julia> ambs = Aqua.detect_ambiguities(TaylorSeries; recursive = true)
2-element Vector{Tuple{Method, Method}}:
(^(a::TaylorN{Interval{T}}, r::S) where {T<:Real, S<:Real} @ TaylorSeriesIAExt ~/.julia/packages/TaylorSeries/l6u6g/ext/TaylorSeriesIAExt.jl:46, ^(a::TaylorN, x::Rational) @ TaylorSeries ~/.julia/packages/TaylorSeries/l6u6g/src/power.jl:50)
(^(a::Taylor1{Interval{T}}, r::S) where {T<:Real, S<:Real} @ TaylorSeriesIAExt ~/.julia/packages/TaylorSeries/l6u6g/ext/TaylorSeriesIAExt.jl:22, ^(a::Taylor1, x::Rational) @ TaylorSeries ~/.julia/packages/TaylorSeries/l6u6g/src/power.jl:50)
I will try to solve them now; they may be the source of the problems...
from taylorseries.jl.
Thanks @lrnv for opening this issue and filing such a detailed report. I will have a look on it, but I will also have to understand the problem.
As a simple solution, have you tested your code with the problematic lines commented?
from taylorseries.jl.
Well, there is no particularly "problematic line". What I do is simply using TaylorSeries.jl to get a derivative, particularly there:
But on the other hand I am not sure if that is a very interesting bug or if we should just dont care
from taylorseries.jl.
Related Issues (20)
- Include offset in struct definition HOT 5
- Compatibility with Multi-Threading HOT 3
- Broaden the applicability of `NumberNotSeries`
- Address ordering for nested `Taylor1`s
- Add Aqua tests
- Can't figure out how to create multivariate approximation HOT 7
- Violation of the (informal) `Number` interface HOT 7
- Integrate is not increasing the order of the underlying Taylor1 HOT 1
- pFq Not compatible with TaylorSeries package HOT 17
- Multivariate Taylor expansion with HypergeometricFunctions HOT 6
- pfq with TaylorN HOT 1
- ERROR: MethodError: no method matching iterate(::Type{HypergeometricFunctions.ℕ₀})
- convert TaylorN object into Num HOT 2
- Bug in Taylor1 constructor for mixtures HOT 1
- What was breaking in 0.16 and 0.17 ? HOT 7
- Wrong method of evaluate
- TaylorSeries v0.17.7 breaks some tests in TaylorIntegration HOT 3
- Use `@allocated`/`@allocations` to test for allocations in mutating methods
- Could someone explain to me what really borke from 0.17 to 0.18 ? HOT 4
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from taylorseries.jl.