Giter Club home page Giter Club logo

Comments (3)

lbenet avatar lbenet commented on September 15, 2024 1

Thanks again for opening this issue, and sorry for addressing it with such a delay.

Recently, #341 was merged and includes additions to extend Aqua-related checks. In the branch lb/iss339 I commented the lines related to the promote_rule pointed out above, which seems unnecesary at least within the tests we have here (maybe they are needed in other packages that use TaylorSeries). The convert method is needed, so I changed a bit its signature; all tests pass.

Can you test if that is enough to solve (or advance) with this issue?

In working on this, I noticed that, once IntervalArithmetic is loaded (so the corresponding pkg-extension is included), Aqua detects the occurrence of some ambiguities:

julia> ambs = Aqua.detect_ambiguities(TaylorSeries; recursive = true)
2-element Vector{Tuple{Method, Method}}:
 (^(a::TaylorN{Interval{T}}, r::S) where {T<:Real, S<:Real} @ TaylorSeriesIAExt ~/.julia/packages/TaylorSeries/l6u6g/ext/TaylorSeriesIAExt.jl:46, ^(a::TaylorN, x::Rational) @ TaylorSeries ~/.julia/packages/TaylorSeries/l6u6g/src/power.jl:50)
 (^(a::Taylor1{Interval{T}}, r::S) where {T<:Real, S<:Real} @ TaylorSeriesIAExt ~/.julia/packages/TaylorSeries/l6u6g/ext/TaylorSeriesIAExt.jl:22, ^(a::Taylor1, x::Rational) @ TaylorSeries ~/.julia/packages/TaylorSeries/l6u6g/src/power.jl:50)

I will try to solve them now; they may be the source of the problems...

from taylorseries.jl.

lbenet avatar lbenet commented on September 15, 2024

Thanks @lrnv for opening this issue and filing such a detailed report. I will have a look on it, but I will also have to understand the problem.

As a simple solution, have you tested your code with the problematic lines commented?

from taylorseries.jl.

lrnv avatar lrnv commented on September 15, 2024

Well, there is no particularly "problematic line". What I do is simply using TaylorSeries.jl to get a derivative, particularly there:

https://github.com/lrnv/Copulas.jl/blob/95fd079798d0db97ce5848dbb6fcf3b83b71af15/src/ArchimedeanCopula.jl#L20-L26

But on the other hand I am not sure if that is a very interesting bug or if we should just dont care

from taylorseries.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.