Comments (4)
Good catch!
The FADHessian
code in master has a bunch of little bugs in both utility functions (e.g. constructors/conversion) and a couple in the mathematical definitions as well. A large number of tiny bugfixes are included in #27, and the state of testing, functional coverage, and performance is greatly improved. A lot of this has to do with the move to automating the definitions of univariate mathematical functions - I'm not even sure how many bugs got fixed by 548be29, since past test coverage was intermittent, but I suspect quite a few. It's likely that by the time #27 lands (in a week or two), this could issue will be fixed (sorry for the wait in the meantime).
I don't have time tonight to check out for sure that it does fix the above, but I'll check tomorrow and report back.
from forwarddiff.jl.
That sounds fine, thanks for the quick response. I tried a handful of other trig functions and did not observe the problem, and I can implement atan with exp by hand in the meantime, so no rush on my account.
Thanks!
from forwarddiff.jl.
I ran your examples, and I can say with more certainty that this is fixed by #27 - I'm seeing a bad_versions/max_iter
ratio of 0.0, even when cranking up max_iter
to 10e6.
The code I used is here; it's basically the code example you gave, but modified to use the new API exposed in #27.
Unless you find anything else, I think this issue can be closed once #27 lands.
from forwarddiff.jl.
This now fixed on master
as of the merging of #27.
from forwarddiff.jl.
Related Issues (20)
- Cancellation with sparse arrays HOT 5
- Implement hessian! for scalar x
- Implement gammalogccdf for ForwardDiff HOT 1
- `ForwardDiff.jacobian` throws error for `fft` HOT 1
- Correctly forming nested dual numbers. HOT 8
- Derivative of a function of derivatives HOT 7
- Symbolics.jl compatibility HOT 1
- Support derivative(f, ::Complex)
- `ForwardDiff` fails to compute correct derivative HOT 3
- Incorrect Hessian by `exp` function HOT 1
- Method ambiguities reported by Aqua HOT 3
- Document internals? HOT 1
- Bug (NaNs) when differentiating eigenvectors of Symmetric matrices
- Error requiring `Symbolics` from `Optimization` HOT 1
- promote_rule ambiguity with AbstractIrrational and ForwardDiff.Dual HOT 2
- Allocation tests broken since Julia 1.9
- LoadError: ArgumentError: Package AdaptStaticArraysCoreExt does not have Adapt in its dependencies: HOT 2
- Working with anonymous functions HOT 2
- DiffResults objects are not re-aliased properly HOT 2
- `gradient!` allocates for matrices but not for vectors
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from forwarddiff.jl.