Giter Club home page Giter Club logo

Comments (4)

jrevels avatar jrevels commented on May 16, 2024

Good catch!

The FADHessian code in master has a bunch of little bugs in both utility functions (e.g. constructors/conversion) and a couple in the mathematical definitions as well. A large number of tiny bugfixes are included in #27, and the state of testing, functional coverage, and performance is greatly improved. A lot of this has to do with the move to automating the definitions of univariate mathematical functions - I'm not even sure how many bugs got fixed by 548be29, since past test coverage was intermittent, but I suspect quite a few. It's likely that by the time #27 lands (in a week or two), this could issue will be fixed (sorry for the wait in the meantime).

I don't have time tonight to check out for sure that it does fix the above, but I'll check tomorrow and report back.

from forwarddiff.jl.

rgiordan avatar rgiordan commented on May 16, 2024

That sounds fine, thanks for the quick response. I tried a handful of other trig functions and did not observe the problem, and I can implement atan with exp by hand in the meantime, so no rush on my account.

Thanks!

from forwarddiff.jl.

jrevels avatar jrevels commented on May 16, 2024

I ran your examples, and I can say with more certainty that this is fixed by #27 - I'm seeing a bad_versions/max_iter ratio of 0.0, even when cranking up max_iter to 10e6.

The code I used is here; it's basically the code example you gave, but modified to use the new API exposed in #27.

Unless you find anything else, I think this issue can be closed once #27 lands.

from forwarddiff.jl.

jrevels avatar jrevels commented on May 16, 2024

This now fixed on master as of the merging of #27.

from forwarddiff.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.