Giter Club home page Giter Club logo

Comments (2)

devmotion avatar devmotion commented on June 19, 2024

My hypothesis (without checking it in detail) is that the problem is that the backend for ChainRulesCore integration (used also for Zygote in your example) uses the rrule to define the pullback function (

AD.@primitive function pullback_function(ab::ReverseRuleConfigBackend, f, xs...)
) but does drop the value of the primal completely, which therefore has to be recovered from the original function in value_and_pullback_function (
function value_and_pullback_function(
) which is e.g. used by derivative (
function derivative(ab::AbstractBackend, f, xs::Number...)
) via jacobian (
function AbstractDifferentiation.jacobian($(args...),)
).

I think one "just" has to define value_and_pullback_function in terms of only rrule for these backends. This should avoid the unnecessary call of the original function.

from abstractdifferentiation.jl.

devmotion avatar devmotion commented on June 19, 2024

Just noticed, there's already #34, #35, #36.

from abstractdifferentiation.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.