Also handle RDS files about rdata.jl HOT 3 CLOSED

I don't fully understand how the interface to the load function is working here. But I have an initial function that works, even though it might skip some things that are important. FileIO.detect_rdata needs to allow both formats (I couldn't figure where this was even defined, but even if I did know, fiddling with binary formats is well outside my area of expertise). So I skip calling it!

You can find this initial implementation here, would be great if someone who knew what they were doing could tidy up the interface stuff and commit to the master fork.

https://github.com/jsams/RData.jl/blob/4cba2af91a7282aa33a86efcc32892cda601f03d/src/RData.jl#L84

edit: doing a proper fork/branch stuff as requested, similar changes as before, but working in a branch now (still no tests and whatnot):
https://github.com/jsams/RData.jl/blob/500aa93121850d97c1c4ad6a5169f94c63d00338/src/RData.jl#L90

from rdata.jl.

@jsams You are welcome to submit a pull request, so that it's easier to review and eventually merge your work (just put your RDS commit in a new branch forked from the current master; the invitation to submit the PR will appear on github automatically). One important component that would be required to merge your work are tests. Please put some small sample test RDS files (ascii and non-ascii) into test/data and add test/RDS.jl with RDS loading tests (should be quite similar to what is already in test/RDA.jl).

FileIO.detect_rdata() is defined in FileIO.jl package. That's the central place where multiple file formats are declared, so that FileIO.load(<filename>) can automatically redirect to the appropriate load() implementation. Eventually, a PR registering RDS file format would have to be submitted to that repository, if we want RDS files to be supported by load().

from rdata.jl.

yea, I can do that eventually. but I need to tend to the workflow that's using this first. Have some deadlines to take care of. Might be a couple of weeks or so before that happens.

from rdata.jl.