Comments (1)
Like in CategoricalArrays, the problem is that even if we took a lock on each setindex!
call, calling getindex
in parallel wouldn't be thread-safe if a new level is added (as the pool may be resized). Yet taking a lock on getindex
would kill performance.
Also, taking a lock on each setindex!
call would make it impossible to run it in parallel, yet that's perfectly safe if you know that you don't add many levels. Not sure whether it's a typical case or not, but that happens e.g. if you reorder values in the array (e.g. sorting).
What we can do without affecting performance is take a lock when adding new levels. That should at least fix the example you give, and adding levels is relatively slow and can't be done in parallel anyway. But that doesn't provide a lot of safety either.
from pooledarrays.jl.
Related Issues (20)
- view of PooledArray HOT 2
- PooledArrays.jl 0.6 release HOT 4
- TagBot trigger issue HOT 9
- Disallow mutable eltype in PooledArray HOT 3
- performance of getindex HOT 10
- implement compactpool! and compactpool functions
- Change order of type parameters
- similar(pa, 0) stopped working HOT 2
- Purity assumption of map HOT 7
- Redesing of PooledArray internals HOT 5
- DataAPI.levels method? HOT 6
- constuctor to create PooledArray sharing a pool from another PooledArray HOT 7
- implement reference offset HOT 4
- improve median for pooled vectors HOT 1
- add insert!
- `pure=true` default to align with Base HOT 12
- Add examples
- bug with empty constructors
- ambiguity in vcat
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from pooledarrays.jl.