Parsers.jl version 2.5 appears to break OpenML.jl about parsers.jl HOT 4 CLOSED

Thanks for the report!

I think this issue comes from ARFFFiles comparing characters to the openquote character in the Parsers.Options ((opts::Parsers.Options).oq) in order to decide how to proceed with parsing (effectively trying to detect what oq should be used for the parsing). The issue in Parserss.jl v2.5 is that opts.oq is now a Parsers.Token whereas before it was a UInt8, and so ARFFFiles end up checking c == opts.oq which in Parsers.jl v2.4 was 0x22 == 0x22 (true) but in v2.5 is 0x22 == Parsers.Token(0x22) (false), and we then end up taking a different code path in ARFFFiles and eventually hit the error you see.
https://github.com/cjdoris/ARFFFiles.jl/blob/4fa74951f8c1142440c3adfb6b2994414a8ea0d7/src/ARFFFiles.jl#L296

This seems like something we should fix in Parsers.jl. But i'm not yet sure what the best fix will be :)

from parsers.jl.

Also ARFFFiles.jl does not seem to have any test, which is sad. Otherwise we could have added it to the Parsers.jl integration tests to help us make sure not to break it

from parsers.jl.

Lol

julia> 0x22 == Parsers.Token(0x22)
false

julia> Parsers.Token(0x22) == 0x22
true

Okay, we literally just missed some == methods -- will put up a PR to fix!

from parsers.jl.

@nickrobinson251 Thanks for the lightning action on this issue.

from parsers.jl.