Giter Club home page Giter Club logo

Comments (4)

jpsamaroo avatar jpsamaroo commented on June 11, 2024

You should be able to change t.mutable to ismutabletype(t) at

t.mutable && Serialization.deserialize_cycle(io, x)
.

from juliadb.jl.

mrufsvold avatar mrufsvold commented on June 11, 2024

I was able to fix this in 1.7 by doing exactly what you suggested.

I know the fix is microscopic, but I'm happy to submit a PR with this.

I also added

# Define check mutability function based on Julia version
_ver1_5orgreater = all(parse.(Ref(Int), split(string(VERSION), ".")) .>= [1,5,0])
if _ver1_5orgreater
    checkmutability(t) = Base.ismutable(t) 
else
    checkmutability(t) = t.mutable
end

So that it will still run in older versions of Julia.

Could leave that in or cut it. Not sure how much backwards compatibility is a priority.

from juliadb.jl.

jpsamaroo avatar jpsamaroo commented on June 11, 2024

A PR would be much appreciated!

1.6 is the new LTS, so I would potentially just set the Julia compat bound in the Project.toml to 1.6. Also, a better way to compare versions is probably VERSION >= v"1.5".

from juliadb.jl.

mrufsvold avatar mrufsvold commented on June 11, 2024

Oh, yeah, that's a way better comparison!

I'll get the PR in shortly. Thanks for your help!

from juliadb.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.