Giter Club home page Giter Club logo

Comments (5)

jbrea avatar jbrea commented on June 2, 2024 1

Could the following line be the problem?

MLJLinearModels.jl/src/mlj/classifiers.jl

Line 72 in 55f22b0

lambda::Real = 1.0

from mljlinearmodels.jl.

ablaom avatar ablaom commented on June 2, 2024

@tlienart Be great if you can take a look at this.

from mljlinearmodels.jl.

jbrea avatar jbrea commented on June 2, 2024

In #124 we discussed a new default for the regularization constant of logistic regression. I think this default hasn't changed everywhere...

from mljlinearmodels.jl.

tlienart avatar tlienart commented on June 2, 2024

In #124 we discussed a new default for the regularization constant of logistic regression. I think this default hasn't changed everywhere...

Sorry guys I don't have much time to look into this in details at the moment but this:

MLJLinearModels.jl/src/glr/constructors.jl

Lines 141 to 142 in 7e34598

function LogisticRegression(
λ::Real=eps(),

seems to suggest the lambda should be fine. In discourse it says that if they use lambda = 1e-6 they get expected results (and in the original example they call the default constructor LogisticClassifier() which should use the default parameter eps()). This suggests that maybe they're not using the latest version as by default lambda should be close to 0?

from mljlinearmodels.jl.

tlienart avatar tlienart commented on June 2, 2024

Thanks a lot @jbrea of course it's that line and

MLJLinearModels.jl/src/mlj/classifiers.jl

Line 29 in 55f22b0

lambda::Real = 1.0
for the LogisticClassifier, I didn't think of the interface... btw it's probably better there's no default parameter in the interface 🙄

from mljlinearmodels.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.