Giter Club home page Giter Club logo

Comments (4)

fkiraly avatar fkiraly commented on July 19, 2024

Short but important comments:
(i) sd/sqrt(n_folds) is not a good estimator of anything, unless all the training and test pairs are non-overlapping!
(ii) I would strongly discourage that the resampling strategy itself produce summaries of any kind. This makes sense as the predictions or loss samples may be needed by meta-learning (e.g., ensembling, tuning) strategies, or evaluation (e.g., CI computation, comparative hypothesis tests)

from mlj.jl.

ablaom avatar ablaom commented on July 19, 2024

Yes, the individual fold estimates are not really independent and sd/sqrt(n_folds) is not ideal. However, in practice, this is the thing routinely reported by data scientists, no? In view of your objection (ii) I suppose we needn't argue this point. I am happy to drop the se method.

At present, there is an evaluate method for every resampler and this returns a single loss estimate. Questions:

  1. Perhaps we instead make it a vector of estimates (a singleton for Holdout), yes?
  2. I only envisaged tuning strategies that make use of a single estimate (or the mean of multiple estimates). Are you suggesting we may want to support tuning strategies that require more than a single estimate? This would complicate the API. If you are suggesting this, could you give some examples?

from mlj.jl.

fkiraly avatar fkiraly commented on July 19, 2024

However, in practice, this is the thing routinely reported by data scientists, no?

Yes, mostly those who use sklearn because sklearn reports it.
But wrong is still wrong...

  1. Perhaps we instead make it a vector of estimates (a singleton for Holdout), yes?

can you explain what you mean here?

  1. Are you suggesting we may want to support tuning strategies that require more than a single estimate?
    This would complicate the API. If you are suggesting this, could you give some examples?

The point is that
(a) mean is somewhat arbitrary. Why force a needless aggregation into the design which is irreversible.
(b) tuning strategies may often use the mean (i.e., a single aggregate), but reasonable evaluation strategies use the full sample of losses, e.g., to get confidence intervals, or measures that are not mean losses (e.g., auroc)
(c) there are some popular tuning strategies which don't only use the mean prediction loss, e.g., some variants of Bayesian optimization (to get an uncertainty), or boosting based ones (to get weights).

from mlj.jl.

ablaom avatar ablaom commented on July 19, 2024

This is now implemented, with all estimates returned as a vector. The current tuning strategies do use the mean, but this can be easliy changed later or new strategies can be addded.

Closing this. Feel free to open an issue for specific tuning strategy enahancement or new strategy.

from mlj.jl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.