Giter Club home page Giter Club logo

Comments (8)

oprypin avatar oprypin commented on May 23, 2024 1

Easy change in the code btw 😁

-            f"{self.metadata.name}",
+            f"hatch.envs.{self.name}",

from hatch-pip-compile.

juftin avatar juftin commented on May 23, 2024

Yeah I removed the project.toml part of it because I didn't have a clean way to tell whether the config was coming via pyproject.toml or hatch.toml.

Do you happen to know if there are easy ways to discern where the config is set?

from hatch-pip-compile.

oprypin avatar oprypin commented on May 23, 2024

I'm guessing there isn't a way to determine that. It looks to be merged without a trace.
https://github.com/pypa/hatch/blob/d666ae7b3dacded86faa96cc0454bb1e69132dc7/backend/src/hatchling/metadata/core.py#L206

I think it's acceptable to not mention that it's pyproject.toml. But I'm mainly saying that mentioning the project name is misleading.

from hatch-pip-compile.

oprypin avatar oprypin commented on May 23, 2024

Could be # via Hatch 'docs' env
or maybe # via tool.hatch.envs.docs

from hatch-pip-compile.

juftin avatar juftin commented on May 23, 2024

Could be # via Hatch 'docs' env
or maybe # via tool.hatch.envs.docs

# via hatch.envs.docs sounds like a winner to me.

How do you feel about # via hatch.envs.default though?

from hatch-pip-compile.

oprypin avatar oprypin commented on May 23, 2024

What do you mean? # via hatch.envs.default is good, if the env is default :)

from hatch-pip-compile.

juftin avatar juftin commented on May 23, 2024

What do you mean? # via hatch.envs.default is good, if the env is default :)

I was thinking of a situation where the default env would get the # via {self.metadata.name} while non-default envs would get # via hatch.envs.{self.name}

But, I think you're right. Just staying consistent with hatch.envs.{self.name} is the most clear

from hatch-pip-compile.

juftin avatar juftin commented on May 23, 2024

🎉 This issue has been resolved in version 1.0.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from hatch-pip-compile.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.