Comments (3)
juftin
commented on August 11, 2024
1
Missed this issue and just saw the PR instead before merging. Agreed, it would be nice to know a KNOWN_AVAILABILITY_STATUSES. CAMPSITE_UNAVAILABLE_STRINGS is early code. I'll take a look at optimizing this soon. Thanks for the contribution in the meantime!
from camply.
gaelollivier
commented on August 11, 2024
Looking at the code, I suspect the API might be returning a new status that isn’t being handled by CAMPSITE_UNAVAILABLE_STRINGS.
One suggestion I can think of to make this more robust: instead of using a deny list for the list of codes that are considered unavailable, could this be changed to an allow list of codes for available statuses?
Alternatively, if you’re worried of false negatives, one option could be to add a list of KNOWN_AVAILABILITY_STATUSES, that lists all the status codes that were seen before / are supported. If the script sees a code that it doesn’t know, then it could log it explicitly and maybe allow the list to be configured?
from camply.
juftin
commented on August 11, 2024
🎉 This issue has been resolved in version 0.16.2 🎉
The release is available on GitHub release
Your semantic-release bot 📦🚀
from camply.
Related Issues (20)
- Add feature to ignore errors instead of stopping the tracking HOT 13
- cannot search on ReserveCalifornia HOT 7
- Notifications over MQTT? HOT 7
- Support for novascotia.goingtocamp.com HOT 4
- Olympic National Park doesn't appear as a WA Recreation area HOT 3
- Ability to specify # of people for a campsite HOT 1
- Reserve California doesn't work for me. HOT 12
- yaml search with ReserveCalifornia fails with TypeError: object of type 'NoneType' has no len()
- Support for manitoba.goingtocamp.com HOT 2
- Trouble using search yaml file with equipment option
- Support for reservations.ontarioparks.com (goingtocamp) HOT 4
- Filter campsites for goingtocamp HOT 3
- GoingToCamp Parks Canada does not identify available sites correctly HOT 12
- `POLLING_INTERVAL_MINIMUM` limit clarification HOT 4
- Generic webhook notification HOT 6
- Reserve California website availability not reflecting in Camply searching HOT 1
- campsite geolocation HOT 6
- Webhook crashes on utf-8 characters HOT 1
- Provider for site specific backcountry permits on nps.gov
- GoingToCamp midnrreservations.com ConnectionError HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from camply.