AWS SDK v3 upgrade is a breaking change about serverless-plugin-warmup HOT 8 CLOSED

Hi @icholy ,

How is the node version upgrade (which includes the upgrade to the v3 of the AWS SDK) affecting you?
The node version and the SDK are internal details of the warmer lambda that is created.
The actual configuration and API doesn't change at all.

from serverless-plugin-warmup.

My projects have sdk v2 listed in their dependencies. The builds start failing with the new version of the warmup plugin because the v3 sdk is missing.

from serverless-plugin-warmup.

I see.

When you deploy, you shouldn't have an explicit dependency on AWS SDK since it's already globally installed in all lambdas.
If you are using serverless-offline or some other approach to run locally, then you need to install it and that's probably what you are hitting.

I can agree. That last update can be considered a major version due to that.

from serverless-plugin-warmup.

In my case, it was the webpack serverless plugin failing to resolve the v3 SDK. I only have a rule for excluding the v2 SDK from the bundle.

from serverless-plugin-warmup.

I see.

As you probably know the order in which you declare plugins in your serverless.yaml matters.
It's important that you configure serverless-plugin-warmup after webpack or any other plugin that tampers with the lambdas. That way the warmer code won't be transpiled (there is no need to) and it will just work.

from serverless-plugin-warmup.

Changing the plugin order doesn't seem to have an effect. I think this is because the warmers are added in the after:package:initialize hook and the webpack bundling happens in the before:package:createDeploymentArtifact hook which will always happen after.

Adding /@aws-sdk\/.*/ to my webpack externals makes it work though.

from serverless-plugin-warmup.

Oh, true that.
Actually, the warmer is re-added on before:package:createDeploymentArtifact just to deal with the webpack plugin modifying and breaking things...

I already told the Serverless guys that they should provide better guidance on the lifecycle events to ensure that plugins use them consistently and we avoid this issues. But it didn't get anywhere. See serverless/serverless#10646

I agree that adding the SDK to externals is the way to go.

from serverless-plugin-warmup.

Thanks for your help with this.

from serverless-plugin-warmup.