Operator doesn't apply pod's ObjectMeta defined on the CustomPodAutoscaler CR. about custom-pod-autoscaler-operator HOT 5 CLOSED

I've tested with the following change:

              template:
                description: The image of the Custom Pod Autoscaler
                properties:
                  metadata:
                    description: 'Standard object''s metadata. More info: https://git.k8s.io/community/contributors/devel/sig-architecture/api-conventions.md#metadata'
                    type: object
                    x-kubernetes-preserve-unknown-fields: true

And it works. Metadata defined on CPA is applied to the created Pod

from custom-pod-autoscaler-operator.

Hey @StefanCenusa sorry about marking this closed without providing a fix version - I was hoping to get a fix cut for this when I noticed this bug that it's introduced: #95

This will be released as soon as I can address this, hoping to have a look this weekend, there's a question of best practices around operators that I've raised here: operator-framework/operator-sdk#5926.

I see you've added a comment on that issue too with a suggestion, let me respond to you there too.

from custom-pod-autoscaler-operator.

@jthomperoo When will this change be released?

from custom-pod-autoscaler-operator.

Hey, no problem, I understand. I have this command that I run after the helm install.

kubectl patch crd custompodautoscalers.custompodautoscaler.com \
    --type json \
    --patch='[{"op": "replace", "path": "/spec/versions/0/schema/openAPIV3Schema/properties/spec/properties/template/properties/metadata/x-kubernetes-preserve-unknown-fields", "value": true}]'

Although, I think that the "bug" this patch introduces is rather a design flaw of how CPA operator controls the (sub)resources.

from custom-pod-autoscaler-operator.

Now available in 1.3.0 🎉

from custom-pod-autoscaler-operator.