"All `models` must be of the same type." about markovify HOT 2 CLOSED

Hi @bfontaine, and good question.

Given that get_model_dict is called on each model why do we need to assert that all models are of the same type?

utils.combine aims to return to you an object of the same class as it received. If it receives two different classes of objects, it doesn't know what to return.

My problem is that I inherit classes from Text and type(my_model) doesn’t take that into account.

One way to accommodate this is to call utils.combine on the underlying Chain instances. E.g., using your example:

class MyText(markovify.Text):
    pass

class MyOtherText(MyText):
    pass

t1 = MyText("foo")
t2 = MyOtherText("bar")

t_combined = MyText.from_chain(markovify.combine([ t1.chain, t2.chain ]).to_json())

from markovify.

Thanks, I’ll do something like that! I’d like to avoid that JSON serialization+deserialization step but the idea stays the same.

from markovify.