Comments (3)
tdnzr
commented on June 30, 2024
1
Hi @jsonMartin, I'm sufficiently unfamiliar with Github that I don't even know how to make a pull request which includes more than one file. So I've submitted two separate pull requests for the plugin and the readme. Hopefully they still make sense.
from readwise-mirror.
jsonMartin
commented on June 30, 2024
1
Hi @tdnzr, thank you for your submitted PRs; no problem on creating separate pull requests, I'm glad you were able to figure it out, it's a good learning exercise. For larger pull requests, it's much more productive to use the Github CLI (though the learning curve is higher), but for small updates like this one Github's site is sufficient.
I just got back from out of town and had a chance to start reviewing the PRs. Congratulations, your tag changes have been accepted and will be incorporated into the next release of the software! Thank you for your contribution.
from readwise-mirror.
jsonMartin
commented on June 30, 2024
Hi @tdnzr , thank you for the suggestion. I think that is a good idea to show the tags by default.
Since you already know the correct places to make the changes, would you feel comfortable making a PR for this? I'd be happy to merge it in
from readwise-mirror.
Related Issues (20)
- Location HOT 2
- Google Play Books links point to Kindle app HOT 1
- Format for highlights is substantially different from the Readwise manual markdown export HOT 1
- Add feature to sort highlights by page location, instead of timestamp HOT 1
- Templating engine
- Metadata sync HOT 1
- Ability to customize file name
- Edit already existed highlights HOT 1
- How does this compare to the readwise official now that it is out? HOT 1
- Filter out highlights that have been discarded in Readwise
- Modification request HOT 2
- Partial note sections HOT 2
- FR: Ability to slugify file names and remove emojis HOT 3
- Does Readwise Mirror support adding links to "View Highlight in Reader"? HOT 5
- Bug: Readwise Mirror generates a locationUrl even for non-books HOT 1
- Are these comments needed for the plugin to operate correctly? HOT 1
- Rate-limit requests when there are issues getting timeout length HOT 3
- Fix Filename Too Long Error
- Ability to include document notes and summaries in export HOT 6
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from readwise-mirror.