[critical] numbers error about json-schema-faker HOT 3 CLOSED

The problem arises somewhere inside of this:

  return random(Math.random() > 0.5, min, max);

as I look down into random.js file I think it's totally overcomplicated. I mean, if I want to generate a random number, why shouldn't I just use pure, simple functions instead of complicated logic combined with faker.random.number?

from json-schema-faker.

m'kay, I'm on my way to fix the bug. It's integer.js. When it's generating {min:5,max:10} then the floor function is perfectly fine. But when it's generating {min:-10,max:-5}, then the floor function might go beyond the scope, e.g. -10.23564568623 and then the floor will make it -11 (beyond scope). Probably need to make it ceil if negative.

Need more tests to solve low level functions :( (non-jsf tests)

from json-schema-faker.

Done, fixed. Currenty in the develop branch.
From this build the problem should be gone. It was happening once per ~10 shots, but anyway, was returning wrong results (and failing tests unexpectedly and nondeterministically).

from json-schema-faker.