Giter Club home page Giter Club logo

Comments (5)

jsikyoon avatar jsikyoon commented on July 30, 2024

Hi tominku,

Thank you for your interesting on my codes!

As I know, Dreamer stores the reply buffer on the disk not memory, but did you experience the memory leak on training? Memory leak means increasement of the memory usage while training.

Bests, Jaesik.

from dreamer-torch.

tominku avatar tominku commented on July 30, 2024

I'm looking around the code before the full run. I noticed that

  1. the code saves an episode at disk everytime an epispde is finished,

  2. But it also maintains the episode in the memory thus every new episode is added to the memory replay buffer.

  3. In training, the agent samples data from the memory, not from the disk. It assumes that all the available episodes data are stored in the memory. Please check the code.

from dreamer-torch.

jsikyoon avatar jsikyoon commented on July 30, 2024

Hi tominku,

Yes, you are right. I assumed they load reply buffer from the disk when it requires because they stored the episodes on disk, but it is not.

One thing we can choose is to modify the codes to load the reply buffer from disk not storing it in memory.

Or a hybrid way could be the reply buffer is stored in memory to the pre-defined limitation and beyond that, they can load it from disk. -> It is harder to implement than naively loading reply buffer from disk I think.

Bests, Jaesik.

from dreamer-torch.

tominku avatar tominku commented on July 30, 2024

Thanks! That might be a good solution.

from dreamer-torch.

jsikyoon avatar jsikyoon commented on July 30, 2024

If you have no comments for this issue, I will close :)

from dreamer-torch.

Related Issues (14)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.