Source configuration stopped working? about currency-conversion HOT 8 CLOSED

@maennchen it's possible hence the question from the beggining. Actually now in iex console this is looking good. Let me find the culprit and don't waste your time for now. I would come back to close it.

from currency-conversion.

@strzibny you have to configure it as config :[your_app_name], [YourCurrencyModule], source: [SourceModule].

Since you defined your module as CurrencyExchange and not `MyProject.CurrencyExchange your second code example is correct.

from currency-conversion.

@maennchen That was just copy & edit mistake. Neither variant seems to work for me. I always get the exchange rates from the default source.

from currency-conversion.

@strzibny Can you IO.inspect what is in config here: https://github.com/jshmrtn/currency-conversion/blob/master/lib/currency_conversion.ex#L117 ?

from currency-conversion.

It's

[
  base_currency: :USD,
  source_protocol: "https",
  source: CurrencyConversion.Source.Test,
  refresh_interval: :manual,
  seed: &MyProject.CurrencyExchange.seed/1
]

So the configuration seems correct.

from currency-conversion.

So the problem is in using seed which is preferred. I don't think this is right. Seed is for populating initial data, but not for updates.

# in update_worker.ex
defp refresh(opts, load_callback \\ &load_from_source/1) do

load_callback would be the seed function.

from currency-conversion.

@strzibny The seed is only called on init, not for manual / automatic refreshes: https://github.com/jshmrtn/currency-conversion/blob/master/lib/currency_conversion/update_worker.ex#L30

I'll do some testing on my own soon. But I honestly think that you're configuring something wrong since a lot of the tests depend on setting a different source: https://github.com/jshmrtn/currency-conversion/blob/master/test/currency_conversion_test.exs#L17

from currency-conversion.

Ya, I made mistake in some tests and it was ordered dependent. Probably all is well. Sorry about the noise.

from currency-conversion.