Giter Club home page Giter Club logo

Comments (9)

edbzn avatar edbzn commented on June 1, 2024 2

Did you try to run ngcc before yarn ngcc # or npm run ngcc ?

Regarding the incorrect path, I think it was corrected in this commit 0d8db0b, we will release it soon.

from devkit.

Sathish787 avatar Sathish787 commented on June 1, 2024 2

@edbzn Thank you so much.
Adding "postinstall": "ngcc" in script section of package.json and running npm run postinstall solved
"Type DynamicModule does not have 'ɵmod' property." issue.

from devkit.

edbzn avatar edbzn commented on June 1, 2024 1

This works, but shouldn't ngcc be executed by Cypress as it compiles the app sources?

@rkrisztian True, the AngularWebpackPlugin must internally run ngcc, it's maybe due to our actual Webpack configuration. I will try a fix.

from devkit.

yjaaidi avatar yjaaidi commented on June 1, 2024

@Sathish787 perfect!
How about the tsconfig path? Do you still have to override it after updating?
Thanks

from devkit.

rkrisztian avatar rkrisztian commented on June 1, 2024

My package.json now looks like this (not showing the whole file):

{
	"scripts": {
		"cypress:open-ct": "ngcc && cypress open-ct",
		"cypress:run-ct": "ngcc && cypress run-ct"
	}
}

This works, but shouldn't ngcc be executed by Cypress as it compiles the app sources?

from devkit.

edbzn avatar edbzn commented on June 1, 2024

Close as it's fixed.

from devkit.

Timeout-Timo avatar Timeout-Timo commented on June 1, 2024

I am not sure if it's fixed. I'm getting this error with Angular 12.2.0 again...

    at getNgModuleDef (http://localhost:36341/__cypress/src/spec-1.js:40378:15)
    at recurse (http://localhost:36341/__cypress/src/spec-1.js:64524:21)
    at recurse (http://localhost:36341/__cypress/src/spec-1.js:64535:17)
    at registerNgModuleType (http://localhost:36341/__cypress/src/spec-1.js:64520:5)
    at new NgModuleFactory$1 (http://localhost:36341/__cypress/src/spec-1.js:64634:13)
    at compileNgModuleFactory__POST_R3__ (http://localhost:36341/__cypress/src/spec-1.js:68333:27)
    at PlatformRef.bootstrapModule (http://localhost:36341/__cypress/src/spec-1.js:68583:16)
    at http://localhost:36341/__cypress/src/spec-1.js:77038:27
    at Generator.next (<anonymous>)
    at http://localhost:36341/__cypress/src/spec-1.js:79516:71
From previous event:
    at Context.thenFn (http://localhost:36341/__cypress/runner/cypress_runner.js:154860:23)
    at Context.then (http://localhost:36341/__cypress/runner/cypress_runner.js:155299:21)
    at Context.<anonymous> (http://localhost:36341/__cypress/runner/cypress_runner.js:170424:21)
    at http://localhost:36341/__cypress/runner/cypress_runner.js:169832:15
From previous event:
    at runCommand (http://localhost:36341/__cypress/runner/cypress_runner.js:169811:8)
    at next (http://localhost:36341/__cypress/runner/cypress_runner.js:169957:14)
From previous event:
    at http://localhost:36341/__cypress/runner/cypress_runner.js:169998:37
From previous event:
    at run (http://localhost:36341/__cypress/runner/cypress_runner.js:169991:21)
    at $Cy.cy.<computed> [as then] (http://localhost:36341/__cypress/runner/cypress_runner.js:170464:11)
    at mount (http://localhost:36341/__cypress/src/spec-1.js:76981:15)
    at Context.<anonymous> (http://localhost:36341/__cypress/src/spec-1.js:79399:80)
    at ZoneDelegate.push.9140.ZoneDelegate.invoke (http://localhost:36341/__cypress/src/628.js:4128:30)
    at ProxyZoneSpec.push.3775.ProxyZoneSpec.onInvoke (http://localhost:36341/__cypress/src/628.js:1821:43)
    at ZoneDelegate.push.9140.ZoneDelegate.invoke (http://localhost:36341/__cypress/src/628.js:4127:56)
    at Zone.push.9140.Zone.run (http://localhost:36341/__cypress/src/628.js:3888:47)
    at Context.<anonymous> (http://localhost:36341/__cypress/src/628.js:2602:37)
    at Context.runnable.fn (http://localhost:36341/__cypress/runner/cypress_runner.js:170688:21)
    at callFn (http://localhost:36341/__cypress/runner/cypress_runner.js:126446:21)
    at Test.../driver/node_modules/mocha/lib/runnable.js.Runnable.run (http://localhost:36341/__cypress/runner/cypress_runner.js:126433:7)
    at http://localhost:36341/__cypress/runner/cypress_runner.js:176693:28
From previous event:
    at Object.onRunnableRun (http://localhost:36341/__cypress/runner/cypress_runner.js:176681:17)
    at $Cypress.action (http://localhost:36341/__cypress/runner/cypress_runner.js:166772:28)
    at Test.Runnable.run (http://localhost:36341/__cypress/runner/cypress_runner.js:174823:13)
    at Runner.../driver/node_modules/mocha/lib/runner.js.Runner.runTest (http://localhost:36341/__cypress/runner/cypress_runner.js:127105:10)
    at http://localhost:36341/__cypress/src/628.js:2654:37
    at ZoneDelegate.push.9140.ZoneDelegate.invokeTask (http://localhost:36341/__cypress/src/628.js:4162:35)
    at Zone.push.9140.Zone.runTask (http://localhost:36341/__cypress/src/628.js:3933:51)
    at drainMicroTaskQueue (http://localhost:36341/__cypress/src/628.js:4348:39)
logError @ cypress_runner.js:190379```

from devkit.

edbzn avatar edbzn commented on June 1, 2024

@Timeout-Timo did you ran ngcc manually? We have not yet implemented the fix for automatically triggering it.

from devkit.

Timeout-Timo avatar Timeout-Timo commented on June 1, 2024

Yes, I did. I also set ngcc in postinstall of my package.json

from devkit.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.