Abstract locatorFor logic about devkit HOT 3 CLOSED

Hi @srlee309, really appreciate your feedback, thank you! That's something we were thinking about. I really like how you abstracted the locatorFor logic. Would you want to create a PR for that? Maybe we can iterate over it, but that's a good starting point. What do you think @yjaaidi ?

from devkit.

Hi @srlee309, thank you for your suggestion.
Actually, you can already use HarnessPredicate to achieve this.
Cf. https://material.angular.io/cdk/test-harnesses/overview#filtering-harness-instances-with-harnesspredicate

This would look something like:

export class TitleHarness extends ComponentHarness {
  ...

  static with(
    options: BaseHarnessFilters
  ): HarnessPredicate<TitleHarness> {
    return new HarnessPredicate(TitleHarness, options);
  }
}

...

getHarness(TitleHarness.with({ selector: '...' })

I totally agree that the HarnessPredicate and ComponentHarness implementation are not very convenient. Cf. angular/components#20871

The goal of this library is to provide a way of using existing harnesses with Cypress, but we are planning to release another library (in this repo) that will make harness writing easier.
We are still not sure if we will extend ComponentHarness or provide a completely different approach that could be framework agnostic.

I will close this issue and add a reference to it in a new issue about harness abstraction in general.

from devkit.

I just opened the issue. @srlee309 if you have any suggestions & ideas, we'd be glad to hear them 😊

from devkit.