Upload multipart to s3 about django-storages HOT 7 CLOSED

Hi Swee,

It's rather hard to review a patch like this. Instead, try the following:

1. Click the "fork" button at the top of the page
2. Add that fork as a remote to your local repository copy of this code (or check it out if you don't have a local repo already).
3. Change the code, commit it, and push to your new remote
4. Come back to Github and create a pull request here (or from your branch -- there's a nice link to add a pull request after you've recently pushed code to a forked repo)

from django-storages.

Cool. I'll do that

Sent from my iPhone

On 24 Feb 2015, at 10:25, Chris Beaven [email protected] wrote:

Hi Swee,

It's rather hard to review a patch like this. Instead, try the following:

Click the "fork" button at the top of the page
Add that fork as a remote to your local repository copy of this code (or check it out if you don't have a local repo already).
Change the code, commit it, and push to your new remote
Come back to Github and create a pull request here (or from your branch -- there's a nice link to add a pull request after you've recently pushed code to a forked repo)
—
Reply to this email directly or view it on GitHub.

from django-storages.

@SmileyChris thanks for stepping in and helping with that. @stlimtat going to take a look at your changes now.

from django-storages.

What's the current status of this?

from django-storages.

Ok, I just found out the multipart implementation on the source code. Sorry xD

It'd be good to mention it on the README though. And also maybe close this issue?

from django-storages.

Had to also find the multipart upload feature in the code. This issue should be closed and maybe documented to avoid confusion.

from django-storages.

Ready to close?

from django-storages.