Giter Club home page Giter Club logo

Comments (1)

ArneBab avatar ArneBab commented on July 26, 2024

I see an even stronger version of this: Extracting the region in an if-clause extracts the whole if-block:

Minimal broken example:

function something (foo) {
  let variable = 0;
  if (foo?.length > 0) { // selected region from foo to 0
    variable = foo;
  }
  return variable;
}

Running js2r-extract-function and giving it the new name longFoo yields:

function longFoo(variable, foo) {
  if (foo?.length > 0) {
    variable = foo;
  }
}

function something (foo) {
  let variable = 0;
  longFoo(variable, foo);
  return variable;
}

But it should create:

function longFoo (foo) {
  return foo?.length > 0;
}

function something (foo) {
  let variable = 0;
  if (longFoo(foo)) {
    variable = foo;
  }
  return variable;
}

from js2-refactor.el.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.