Unused promises hang around and don't get resolved. about js-data-angular HOT 2 CLOSED

@MattAitchison After looking closer angular-data's source, I think I know why you have the pending promises. There are a couple places where $q.defer() is used, which creates a pending promise, but a different existing promise is returned instead, so the empty, useless pending promise gets thrown away. I think in your case the following code:

defer.promise.finally(function () {
  pendingPromisses--;
});

creates a reference to the empty, useless promise so it never gets garbage collected.

I don't think the solution is to modify your code. I think the better way is to refactor angular-data so it only creates a new promise when it's sure it will use that promise, instead of always creating one and sometimes throwing it away for another. Angular-data stills performs well from an API correctness perspective, but this needs to be fixed. I'll make it first on my list when I swing back around to angular-data from reheat.

I know exactly how to fix it, but it will take some work.

from js-data-angular.

Ah okay that makes sense. Thanks for the help!

And its no rush. This isn't a required feature for my app.

from js-data-angular.