Comments (14)
Sorry, but if the link couldn't be accessed, then the logical behaviour is to advise the user, preventing to access him to an unexisting folder.
Won't fix.
from cmfilemanager.
I think you misunderstood the issue. Trying to explain it better.
- /folder/ is a folder with "random" content.
- /folder/symlink/ is a broken symlink.
Expected result: I can list the content of /folder/ and access all the normal files/folders in there. Only accessing /folder/symlink/ fails.
Actual result: Accessing /folder/ fails, the content of it isn't listed. Subfolders like /folder/subfolder/ can be accessed by typing their folder names in the location field though.
from cmfilemanager.
I tried to reproduce but i didn't found the error.
adb shell
su
mkdir /system/tests
cd /system/tests
mkdir real
touch 1.txt
touch 2.txt
ln -s real2 symlink
No error here when access /system/tests.
from cmfilemanager.
Use a Nexus device (/sdcard/ is an alias of /data/media/ on those. On all(?) other devices /sdcard/ is a mount point so it won't be repoducable there as you can't create the "broken" symlink)
adb shell
su
cd /data/media/
mkdir test
ln -s test symlink
then try to open /sdcard/ in File Manager
from cmfilemanager.
I don't have a device with thhis layout, and i cannot create links in the sdcard for testing.
I uploaded an apk with the a fix at https://www.dropbox.com/s/kvg731bhk3cl5lk/CMFileManager_experimental_20121004.apk.
Could upload to yout device and report back?. I also need a full logcat for the list and cd command (with ok and error).
Thanks.
from cmfilemanager.
Jorge, Danesh has a nexus device. He may be able to help test this for
you.
On Nov 4, 2012 11:30 AM, "Jorge Ruesga" [email protected] wrote:
I don't have a device with thhis layout, and i cannot create links in the
sdcard for testing.I uploaded an apk with the a fix at
https://www.dropbox.com/s/kvg731bhk3cl5lk/CMFileManager_experimental_20121004.apk
.Could upload to yout device and report back?. I also need a full logcat
for the list and cd command (with ok and error).Thanks.
—
Reply to this email directly or view it on GitHubhttps://github.com//issues/28#issuecomment-10052263.
from cmfilemanager.
Thanks, Daniel. I will contact to him.
from cmfilemanager.
Fixed in change http://review.cyanogenmod.org/#/c/25899/
from cmfilemanager.
the Experimental Apk Works. Thanks For The Quick fix
I Assume symlinks (Non-broken Ones) Not Being Shown At All In The File List Is A Different, Known Issue?
from cmfilemanager.
Could you post a logcat of the list command to see what links are displaying? Probably the broken symlink is breaking the symlink-real output.
from cmfilemanager.
It doesn't show any symlinks at all for me. Not just in the folder with the broken one but anywhere.
E.g. no /sdcard/ and /etc/ in /.
Logcat at http://pastebin.com/iFCWVKfC (grabbing a logcat without a PC really sucks, I'll post a better one later if needed)
from cmfilemanager.
Looks like symlink data is not listed. This need a more deep review.
from cmfilemanager.
I got confused, because I see that the logcat is in reverser order.
The listing is ok. The data is well paired. The listing found 4 symlinks (>SIMLINKS>) and all information (>SIMLINKS_DATA>) is present for this 4 symlinks: name, abs path and ref path
V/19:02:07.175 ShellConsole( 5009) >SIMLINKS>
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< SYMLINKS FOUND
V/19:02:07.175 ShellConsole( 5009) lrwxrwxrwx root root 2012-11-04 18:38 d -> /sys/kernel/debug
V/19:02:07.175 ShellConsole( 5009) lrwxrwxrwx root root 2012-11-04 18:38 etc -> /system/etc
V/19:02:07.175 ShellConsole( 5009) lrwxrwxrwx root root 2012-11-04 18:38 sdcard -> /storage/sdcard0
V/19:02:07.175 ShellConsole( 5009) lrwxrwxrwx root root 2012-11-04 18:38 vendor -> /system/vendor
V/19:02:07.175 ShellConsole( 5009) >SIMLINKS_DATA>
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< NAME (SYMLINK)
V/19:02:07.230 ShellConsole( 5009) d
V/19:02:07.230 ShellConsole( 5009) etc
V/19:02:07.230 ShellConsole( 5009) sdcard
V/19:02:07.230 ShellConsole( 5009) vendor
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< ABS PATH (REAL)
V/19:02:07.230 ShellConsole( 5009) /sys/kernel/debug
V/19:02:07.230 ShellConsole( 5009) /system/etc
V/19:02:07.230 ShellConsole( 5009) /storage/sdcard0
V/19:02:07.230 ShellConsole( 5009) /system/vendor
<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<<< REF INFO (REAL)
V/19:02:07.277 ShellConsole( 5009) drwxr-xr-x root root 1970-01-01 01:00 debug
V/19:02:07.277 ShellConsole( 5009) drwxr-xr-x root root 2012-11-03 22:43 etc
V/19:02:07.277 ShellConsole( 5009) drwxrwxr-x root sdcard_rw 2012-11-04 18:19 sdcard0
V/19:02:07.277 ShellConsole( 5009) drwxr-xr-x root shell 2012-11-02 21:25 vendor
I don't see any bad behaviour here. Are these the expected symlinks?
A silly question, do you have enabled the view of symlinks? This can be enabled in the title bar. If you press the arrow, in the eye icon is the option "Show symlinks" that enable the visualization of symlinks.
from cmfilemanager.
Ah damn, that show symlinks option was disabled.
However info those options are quite hidden there, is have never looked for options in that place. Maybe they'd better be placed in the main preferences screen?
from cmfilemanager.
Related Issues (20)
- Change application name to 'File Manager' HOT 1
- Actions menu icon HOT 2
- Strings cleanup HOT 1
- Replace 'arrows' actions icon with new '8-dot' icon HOT 1
- Bookmark icons HOT 5
- Possible design for tablet HOT 4
- How does compression/uncompress work? HOT 3
- crash opening /data/media/ and /sdcard/ HOT 5
- Inability to move files. HOT 2
- Error when moving file to root of "sdcard" HOT 8
- Network support
- com.cyanogenmod.filemanager.console.CommandNotFoundException: bash HOT 2
- CMFileManager does not recoginise mkv and rmvb video file HOT 1
- CMFileManager cause system to crash and go into bootanimation when unmounting usb storage HOT 2
- Send *.apk files via bluetooth HOT 4
- CMFileManager and Android 6.0 (external storage) HOT 1
- rename confirm dialog accept fails HOT 1
- Engineering import studio times wrong
- I miss this app. HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from cmfilemanager.