Giter Club home page Giter Club logo

Comments (7)

piefel avatar piefel commented on July 20, 2024 1

I can create a small Git repo and share the link: https://github.com/piefel/junit5-migration-maven

from jqwik.

jlink avatar jlink commented on July 20, 2024

Thanks for pointing that out. I'll have a look at it...

from jqwik.

jlink avatar jlink commented on July 20, 2024

If I understand you correctly, it's basically an IntelliJ bug - maybe you can paste in the youtrack ID from youtrack.jetbrains.com so that I can follow the progress.

Creating two artefacts would be

  1. quite a big change to the way I currently do releases
  2. an additional burden for those users that don't run into your problem

Your second suggestion does also not feel right, because it would lie about the real dependency.

I'm not a maven expert, so here's my question: Does Maven provide a way to exclude transparent dependencies (I loosely remember an tag)? Gradle also has such a mechanism, and I could document the steps to work around this IntelliJ issue until it will be resolved.

What do you think?

from jqwik.

piefel avatar piefel commented on July 20, 2024

It is an IntelliJ problem, that’s correct. There is no YouTrack ticket, only my support ticket which is not public. I don’t see why test discovery should be affected by things on the classpath, but there it is. The IntelliJ test support may depend too much on the structure that JUnit 5 uses itself (separated API and engine).

I don’t know what transparent dependencies are, but assuming you mean transitive, then of course, they can be excluded, and that is in fact what I’m doing:

    <dependency>
        <groupId>net.jqwik</groupId>
        <artifactId>jqwik</artifactId>
        <version>${jqwik.version}</version>
        <scope>test</scope>
        <exclusions>
            <exclusion>
                <groupId>org.junit.platform</groupId>
                <artifactId>junit-platform-engine</artifactId>
            </exclusion>
        </exclusions>
    </dependency>

About the ‘lying’ part: I’m not sure it is lying. Nothing in the jqwik library depends on the platform engine. To actually run the tests it is needed, but that is a dependency of the test runtime. You wouldn’t normally include the EL dependency in a WAR when you know it’s going to run in a Tomcat.

Feel free not to fix the dependency, but perhaps leave open this ticket for reference if other people stumble upon the same issue.

from jqwik.

jlink avatar jlink commented on July 20, 2024

"transparent" should be "transitive" of course :-)

Leaving the issue open for the time being sounds like a good suggestion. I will add the related Gradle code in another comment.

from jqwik.

jlink avatar jlink commented on July 20, 2024

@piefel Can you point to an example where I can see the IntelliJ bug or the issue tracker ID for it? I could not reproduce your problem in my experiments.

from jqwik.

jlink avatar jlink commented on July 20, 2024

Has hopefully been resolved with #37

from jqwik.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.