Comments (7)
I'm super into this investigation! Absolutely happy to chime in as well!
from prow-github-actions.
Hi @ashleypafko - I personally haven't been investigating this (I wish I had more time to do open source stuff
I'm open to any contributions on this and I'd be super interested to hear what could work. If you want to pick this up, I'd be happy to see what you come up with!
from prow-github-actions.
@carolynvs - Hmmmm. I'm not sure; I had looked at re-using some Go code from prow and test-infra early on, but at the time, the Go octokit API library was being archived. But seems there is a google maintained go-github library nowadays that may work for our needs.
I'm also not sure what real benefit we would get from a full re-write vs a port. I'd consider this github action fairly stable and I worry about introducing more complexity for users and maintainers if we wanted to re-using much logic from kubernetes in Go.
Generally, I'm not a fan of re-writing this action in Go. I like having nock
and jest
for API mocking and in my experience, that's painful in Go.
But it sounds like you're asking if we could look into somehow importing that Go code and wrapping it around executors we could use in this javascript action? I'd be all for investigating that and if it's stable, let's do it!
Opinions welcome!
from prow-github-actions.
Maybe a simple example of how we could do that with a small go library would help me wrap my head around what you're suggesting. If I had to read between the lines, sounds like how you'd do that is
- import the necessary libraries with public methods into our own go program
- build/compile that binary
- have our action (written in TS) execute that binary with some inputs, deriving the outputs
?
from prow-github-actions.
Oh yeah sorry, I totally am not interesting in reimplementing the gh-action in Go!
I mostly wanted to make sure that if one was super distasteful that I knew not to waste time going down that path.
from prow-github-actions.
Hey @carolynvs & @jpmcb ! I've been keeping an eye on this issue and pretty interested in this feature... just curious, are you guys currently working on this / is it close to being done? Love the project
from prow-github-actions.
Same, I haven't had time to work on this but would be super interested in seeing it implemented!
from prow-github-actions.
Related Issues (20)
- Choose merge method when auto-merging HOT 2
- Support workflow_run HOT 7
- [BUG] Labeler triggers abuse detection HOT 3
- Bump to latest version of `@actions/github`
- [Feature] Surface org membership errors
- [CI / CD] System to perform tasks on a test repo, end to end
- test bug HOT 1
- blank issue HOT 1
- Support OWNERS files HOT 2
- Update GitHub templates HOT 1
- Make a `v1.2.0` release
- support `issue_comment: types: [edited]`
- Suggestion: Reply with comment with the slash command result HOT 4
- [maintainers] Tests are broken in GitHub actions HOT 4
- Recognize /lgtm and /approve from PR review comment HOT 2
- Option Retrieve OWNERS from alternate sources HOT 13
- [BUG] Bot should ignore / commands that are embedded in code HOT 4
- Deploy and manage documentation site from `docs/` folder using GitHub pages
- Migrate action to run on Node16 HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from prow-github-actions.