[Feature Request] The ability to toggle off the conversion of Minecraft color codes to MiniMessage codes within placeholders about announcerplus HOT 6 CLOSED

I understand. To be clear, the reason I decided to use external messages for joining/quitting is for attempting a workaround that allows me to send notifications to other servers through Bungee. Actually using hopecommander with a bungeebroadcast plugin for those messages. Though this bug doesn't actually prevent that as long as I don't use the suffix placeholders, so just thought I'd mention it. Thanks.

from announcerplus.

As much as I would like to fix this, it's very much an edge case and fixing it simply would break other things which are more commonly done. There are of course much more complicated solutions to the one I'm thinking of that could be attempted, but that's more than I'm willing to do for an edge case involving legacy codes like this atm.

from announcerplus.

An option to "not convert" is probably a no-go for a variety of reasons (it doesn't align with the vision for the plugin, and also technical reasons).

The conversion from legacy should be lossless however. Do you have an example of a failed conversion that "doesn't work at all in Minecraft"? The conversion seems to work fine in my testing.

from announcerplus.

Join commands as they appear in the given join/quit file:

What appears in-game:

The user's suffix in LuckPerms:

What should appear when this placeholder is parsed in-game:

Now that I think about it, this may be more of a bug than anything as I'm not sure when you'd want it to convert a placeholder's contents like that. Perhaps it's simply converting the Minecraft codes into the new format but not processing them when it's done from a placeholder.

from announcerplus.

I think the best solution is for you to use the built-in join-messages/join-broadcasts config options instead of using a second plugin to broadcast messages through a command. Either that or use the /ap broadcast command. Both of these solutions require changing the text in the AP config files from legacy to MiniMessage, any legacy placeholders will be upgraded automatically.

Although there is an unintended side-effect happening there from parsing placeholders in commands, it's not something you would encounter with a more sane/standard/supported setup of using the in-built config options or commands instead of executing another plugin's command, and so it's probably not going to be fixed. Placeholder parsing in commands is needed for %player_name% placeholders for example, and we can't know which placeholders are needed for the command and which are meant to be parsed by the command we are executing. Given we can't remove placeholder parsing for commands as is, we also can't remove format conversion as this would break executing /ap broadcast with placeholders from config commands, which is higher priority to work than third party plugin commands.

from announcerplus.

I've opened a tracking issue for a potential long-term solution #113.

from announcerplus.