Comments (11)
@annawinkler we are at 80% at this point so there is still room for improvement. There are still some easy-to-implement tests in the command.standard package (the package that contains the basic commands).
@TunedMidja and @tumit thanks again for your awesome constributions 👍
from extendedcli.
@bit-man Codecov says 95%. I think your tool is not considering branch coverage, which codecov does (thus the difference).
from extendedcli.
Trying to reach 100% coverage just discovered that org.extendedCLI.argument.DefaultArgument#equals cannot be fully covered because constructor does not allow name to be null (check org.extendedCLI.argument.DefaultArgument#checkValidName) then the true branch for the next condition will never be reached
from extendedcli.
@bit-man nicely spotted! I usually use the eclipse template to generate methods such as equals
and hashCode
, which often leads to bugs like that (unfortunately).
If you want, you can fix it yourself (by removing the appropriate clause(s)), otherwise i'll change when i get the time 😉
from extendedcli.
Hi there - I'm interested in helping out. Are you using Java 8 or 9 for this project?
from extendedcli.
Cool @annawinkler ! I'm using java 8. I've not yet read much about Java 9. I've never even planned on upgrading ahah. Tell me if you run into any issues in the setup!
from extendedcli.
Awesome - Java 8 is good for me too. I'll let you know how it goes.
from extendedcli.
@annawinkler, I've added quite a few tests for CLIBuilder, have a look here:
#2
But there are still several classes with low coverage so you can pick up where I left off if you want.
from extendedcli.
Cool - if there's something left to do I'll look at it otherwise I'll find another project to contribute to.
from extendedcli.
Added #5 to improve command.standard coverage.
from extendedcli.
Coverage is already at 100%. Could you please close this issue?
from extendedcli.
Related Issues (3)
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from extendedcli.