Giter Club home page Giter Club logo

Comments (11)

JPDSousa avatar JPDSousa commented on September 24, 2024 3

@annawinkler we are at 80% at this point so there is still room for improvement. There are still some easy-to-implement tests in the command.standard package (the package that contains the basic commands).

@TunedMidja and @tumit thanks again for your awesome constributions 👍

from extendedcli.

JPDSousa avatar JPDSousa commented on September 24, 2024 1

@bit-man Codecov says 95%. I think your tool is not considering branch coverage, which codecov does (thus the difference).

from extendedcli.

bit-man avatar bit-man commented on September 24, 2024 1

Trying to reach 100% coverage just discovered that org.extendedCLI.argument.DefaultArgument#equals cannot be fully covered because constructor does not allow name to be null (check org.extendedCLI.argument.DefaultArgument#checkValidName) then the true branch for the next condition will never be reached

screenshot from 2017-10-23 06-11-46

from extendedcli.

JPDSousa avatar JPDSousa commented on September 24, 2024 1

@bit-man nicely spotted! I usually use the eclipse template to generate methods such as equals and hashCode, which often leads to bugs like that (unfortunately).

If you want, you can fix it yourself (by removing the appropriate clause(s)), otherwise i'll change when i get the time 😉

from extendedcli.

annawinkler avatar annawinkler commented on September 24, 2024

Hi there - I'm interested in helping out. Are you using Java 8 or 9 for this project?

from extendedcli.

JPDSousa avatar JPDSousa commented on September 24, 2024

Cool @annawinkler ! I'm using java 8. I've not yet read much about Java 9. I've never even planned on upgrading ahah. Tell me if you run into any issues in the setup!

from extendedcli.

annawinkler avatar annawinkler commented on September 24, 2024

Awesome - Java 8 is good for me too. I'll let you know how it goes.

from extendedcli.

TunedMidja avatar TunedMidja commented on September 24, 2024

@annawinkler, I've added quite a few tests for CLIBuilder, have a look here:
#2
But there are still several classes with low coverage so you can pick up where I left off if you want.

from extendedcli.

annawinkler avatar annawinkler commented on September 24, 2024

Cool - if there's something left to do I'll look at it otherwise I'll find another project to contribute to.

from extendedcli.

annawinkler avatar annawinkler commented on September 24, 2024

Added #5 to improve command.standard coverage.

from extendedcli.

bit-man avatar bit-man commented on September 24, 2024

Coverage is already at 100%. Could you please close this issue?

screenshot from 2017-10-22 18-18-24

from extendedcli.

Related Issues (3)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.