Giter Club home page Giter Club logo

Comments (12)

Josverl avatar Josverl commented on June 21, 2024 1

Those stubs are not maintained by me, and are indeed incorrect.

I think mine are correct,
    def __init__(self, scl, sda, *, freq=400000, timeout=50000) -> None:

It should be possible to reconfigure your project to use the more up to date stubs

And/or raise this with the Pico maintainer

from micropython-stubber.

couillonnade avatar couillonnade commented on June 21, 2024

Sorry, wrong repo.

from micropython-stubber.

Josverl avatar Josverl commented on June 21, 2024

If this is for micropython stubs then I could move the issue, but not sure if I can understand the question or issue withiuth details of the port board and version of the stubs in that case

from micropython-stubber.

couillonnade avatar couillonnade commented on June 21, 2024

I am using Pico-W-Stub with vscode and when machine.SoftI2C, Pylance ask for one more parameter (the id).

umachine has SoftI2C class with this:
def __init__(self, id: int, /, *, scl: Pin, sda: Pin, freq: int = 400_000):

However, the id parameter should not be there. Removing it solves Pylance error.
I am not really familiar with the structure of stubs nor a Python guy so please let me know if this is clear or not.

image

from micropython-stubber.

couillonnade avatar couillonnade commented on June 21, 2024

Thanks! I figured out it was not the right repo that's why I closed it. I already raise it to the maintainer but no feedback so far.

I'll read how to switch to your stubs and replace it automatically.

from micropython-stubber.

Josverl avatar Josverl commented on June 21, 2024

NP, happy to help

from micropython-stubber.

couillonnade avatar couillonnade commented on June 21, 2024

Quick question about the stub since I could not find answer in the docs: why are there both init (initialize) and init function ? Not sure about the logic behind the duplicate def init()?

from micropython-stubber.

Josverl avatar Josverl commented on June 21, 2024

All classes should have an init
I try to deduce the parameter signature from the documentation of the class

https://docs.micropython.org/en/latest/library/machine.I2C.html#machine.SoftI2C

class machine.SoftI2C(scl, sda, *, freq=400000, timeout=50000)

The I2C class also has an init method documented, with a slightly different signature

I2C.init(scl, sda, *, freq=400000)

Perhaps this is a Documentation error?

Have you tested if the SoftI2C class accepts/has both methods?

On the board firmware I find the SoftI2C method is reported as having the init method

https://github.com/Josverl/micropython-stubs/blob/main/stubs/micropython-v1_19_1-rp2/machine.py#L221-L222

from micropython-stubber.

couillonnade avatar couillonnade commented on June 21, 2024

You are right and the documentation is right. I did not see it at first because I only looked at RP2 port and not the general documentation!

from micropython-stubber.

Josverl avatar Josverl commented on June 21, 2024

Do you have a link to the page with the wrong info?
Then I can send a PR to correct the docs

from micropython-stubber.

couillonnade avatar couillonnade commented on June 21, 2024

I searched but what I see now is correct. The only thing I can think about is I may have looked at an older version of the doc. Thanks for your patience!

image

from micropython-stubber.

Josverl avatar Josverl commented on June 21, 2024

No problem 👍

from micropython-stubber.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.