Comments (5)
Branch protections get set up on the main
branch no matter what:
from create-typescript-app.
"We will protect you whether you like it or not!"
from create-typescript-app.
I wound up deleting my main
branch protection and recreating it as best I could remember.
Would likely be fixed by #1309
I think this will still be an issue there? Since you might not want to preserve rulesets changes.
Right, I misunderstood this GitHub feature. I thought it let you configure rulesets via code, which really would solve the problem.
Still, I wonder if you could create a new ruleset and let the user delete whatever existing branch protections they had before once they're ready to commit. At least then the new ruleset wouldn't be overriding anything.
from create-typescript-app.
Yeah it's annoying 😕 I've been inconvenienced by this before. It would be nice if the previous state of things could be stored somewhere.
Proposal: how about adding something to the output at the end of --mode migrate
? It should:
- indicate explicitly that GitHub settings were made
- show the command to run a script that sets values back to what they were
...where the script is a file written to disk?
Would likely be fixed by #1309
I think this will still be an issue there? Since you might not want to preserve rulesets changes.
from create-typescript-app.
was surprised to see that changes had been made to my repo via the GitHub API (branch protection rules) independently of that PR.
Just to satisfy my own curiosity, what was the nature of the changes made? And to which branch?
from create-typescript-app.
Related Issues (20)
- 🚀 Feature: --mode migrate should prompt for the base
- 🐛 Bug: Generated legacy ESLint config should use plugin:markdown/recommended-legacy HOT 1
- 🚀 Feature: a github action to track bundle size HOT 2
- 🐛 Bug: --mode migrate crashes on editing an "accepting prs" label if "status: accepting prs" already exists HOT 1
- 🐛 Codecov now needs a CODECOV_ACTION token in v4 HOT 1
- 🐛 Bug: husky: install command is deprecated HOT 1
- 🛠️ Repo: @types/[email protected] is now a deprecated types stub HOT 1
- 🚀 Feature: Renovate config use preset config:recommended or config:best-practices HOT 4
- 🚀 Feature: Remove padding-line-between-statements ESLint rule HOT 1
- 🚀 Feature: Increase Renovate minimumReleaseAge to 7 days HOT 1
- 🚀 Feature: Remove the manual disable of no-case-declarations HOT 1
- 🐛 Bug: Temporarily remove deprecation/deprecation HOT 1
- Dependency Dashboard
- 🐛 Bug: Don't include chore PRs in changelogs and release notes
- 🚀 Feature: move perfectionist errors to warn HOT 4
- 🐛 Bug: Crash in --mode create if pnpm version mismatches HOT 1
- 🚀 Feature: make no-unused-variables more permissive HOT 2
- 🚀 Feature: Use get-github-auth-token instead of $(gh auth token) HOT 1
- 🚀 Feature: Consider having Renovate only update major and minor versions, not patch versions HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from create-typescript-app.