Giter Club home page Giter Club logo

Comments (5)

JoshuaKGoldberg avatar JoshuaKGoldberg commented on September 24, 2024 1

Branch protections get set up on the main branch no matter what:

`PUT /repos/${options.owner}/${options.repository}/branches/main/protection`,

from create-typescript-app.

johnnyreilly avatar johnnyreilly commented on September 24, 2024 1

"We will protect you whether you like it or not!"

from create-typescript-app.

danvk avatar danvk commented on September 24, 2024 1

I wound up deleting my main branch protection and recreating it as best I could remember.

Would likely be fixed by #1309

I think this will still be an issue there? Since you might not want to preserve rulesets changes.

Right, I misunderstood this GitHub feature. I thought it let you configure rulesets via code, which really would solve the problem.

Still, I wonder if you could create a new ruleset and let the user delete whatever existing branch protections they had before once they're ready to commit. At least then the new ruleset wouldn't be overriding anything.

from create-typescript-app.

JoshuaKGoldberg avatar JoshuaKGoldberg commented on September 24, 2024

Yeah it's annoying 😕 I've been inconvenienced by this before. It would be nice if the previous state of things could be stored somewhere.

Proposal: how about adding something to the output at the end of --mode migrate? It should:

  • indicate explicitly that GitHub settings were made
  • show the command to run a script that sets values back to what they were

...where the script is a file written to disk?

Would likely be fixed by #1309

I think this will still be an issue there? Since you might not want to preserve rulesets changes.

from create-typescript-app.

johnnyreilly avatar johnnyreilly commented on September 24, 2024

was surprised to see that changes had been made to my repo via the GitHub API (branch protection rules) independently of that PR.

Just to satisfy my own curiosity, what was the nature of the changes made? And to which branch?

from create-typescript-app.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.