React generates empty classnames in DOM if value is an empty string about classcat HOT 4 CLOSED

@vladshcherbin Can <div class=""/> break an app?

Hyperapp's output is: <div class /> by the way.

from classcat.

@jorgebucaran I don't think it can break an app.

Returning undefined just gives a clean html output without empty classes.

from classcat.

@vladshcherbin Return undefined and you may also end up with "undefined my-class" if you're concatenating Classcat's output with a string as someone already pointed out in the classNames PR.

React, Hyperapp should solve this, not Classcat. I want a clean DOM too, but changing Classcat to monkey-patch a JavaScript framework is worse.

I'll fix this in Hyperapp in jorgebucaran/hyperapp#754.

Thanks! 👋

from classcat.

@jorgebucaran sure, thanks :)

from classcat.