Giter Club home page Giter Club logo

Comments (6)

bulfinch avatar bulfinch commented on May 22, 2024 1

Thanks for the response. Here are some of the shows.
Twisted Metal (2023) https://thetvdb.com/series/twisted-metal Under the Queen's Umbrella (2023) https://thetvdb.com/series/under-the-queens-umbrella Halfway Home (2007) https://thetvdb.com/series/halfway-home Domina (2021) https://thetvdb.com/series/domina One Piece (2023) https://thetvdb.com/series/one-piece-2022

Thanks!

I've been trying to replicate this, but unfortunately i don't see the same behavior. I added both 'Domina' & 'One Piece' to my server, and both got a tvdb ID in the Plex API response when running Maintainerr.

My theory is that Plex servers don't update their metadata that often and will include the data that was available when the show was added. The tvdb ID was probably missing when you added it to your Plex instance. This is just a guess, though, I'm not sure how it works exactly.

I added some extra fallback logic, so hopefully that's enough to catch this case. I also improved the logs a bit, when this happens you should now see the name of the show that failed.

It would be a huge help if you could report the result after the next release. Thanks in advance!

Wanted to report back that this looks good. The error returns as tvdb id. The one error i have now was the result of a mismatched show. A show named Anna was a 2022 show in sonarr but a different Anna (2021) in Plex.

from maintainerr.

jorenn92 avatar jorenn92 commented on May 22, 2024

Hi, thank you for this report!.

When Maintainerr checks a Sonarr / Radarr rule value, it has to first fetch the tmdb / tvdb ID. Mostly, this is available in the Plex response. But for some shows, Plex doesn't have these IDs. When that happens, there are a few fallback mechanisms to still find the tvdbid for the show. We need this ID, because we can't query the Sonarr api without it.

These fallback mechanisms appear to have failed for 16 of your shows.
Could you give me 2 or 3 example shows that failed? These are good cases to toughen this fallback system.

from maintainerr.

bulfinch avatar bulfinch commented on May 22, 2024

Thanks for the response. Here are some of the shows.

Twisted Metal (2023) https://thetvdb.com/series/twisted-metal
Under the Queen's Umbrella (2023) https://thetvdb.com/series/under-the-queens-umbrella
Halfway Home (2007) https://thetvdb.com/series/halfway-home
Domina (2021) https://thetvdb.com/series/domina
One Piece (2023) https://thetvdb.com/series/one-piece-2022

from maintainerr.

jorenn92 avatar jorenn92 commented on May 22, 2024

Thanks for the response. Here are some of the shows.

Twisted Metal (2023) https://thetvdb.com/series/twisted-metal Under the Queen's Umbrella (2023) https://thetvdb.com/series/under-the-queens-umbrella Halfway Home (2007) https://thetvdb.com/series/halfway-home Domina (2021) https://thetvdb.com/series/domina One Piece (2023) https://thetvdb.com/series/one-piece-2022

Thanks!

I've been trying to replicate this, but unfortunately i don't see the same behavior.
I added both 'Domina' & 'One Piece' to my server, and both got a tvdb ID in the Plex API response when running Maintainerr.

My theory is that Plex servers don't update their metadata that often and will include the data that was available when the show was added. The tvdb ID was probably missing when you added it to your Plex instance. This is just a guess, though, I'm not sure how it works exactly.

I added some extra fallback logic, so hopefully that's enough to catch this case. I also improved the logs a bit, when this happens you should now see the name of the show that failed.

It would be a huge help if you could report the result after the next release. Thanks in advance!

from maintainerr.

jorenn92 avatar jorenn92 commented on May 22, 2024

🎉 This issue has been resolved in version 1.6.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

from maintainerr.

jorenn92 avatar jorenn92 commented on May 22, 2024

Thanks for the response. Here are some of the shows.
Twisted Metal (2023) https://thetvdb.com/series/twisted-metal Under the Queen's Umbrella (2023) https://thetvdb.com/series/under-the-queens-umbrella Halfway Home (2007) https://thetvdb.com/series/halfway-home Domina (2021) https://thetvdb.com/series/domina One Piece (2023) https://thetvdb.com/series/one-piece-2022

Thanks!
I've been trying to replicate this, but unfortunately i don't see the same behavior. I added both 'Domina' & 'One Piece' to my server, and both got a tvdb ID in the Plex API response when running Maintainerr.
My theory is that Plex servers don't update their metadata that often and will include the data that was available when the show was added. The tvdb ID was probably missing when you added it to your Plex instance. This is just a guess, though, I'm not sure how it works exactly.
I added some extra fallback logic, so hopefully that's enough to catch this case. I also improved the logs a bit, when this happens you should now see the name of the show that failed.
It would be a huge help if you could report the result after the next release. Thanks in advance!

Wanted to report back that this looks good. The error returns as tvdb id. The one error i have now was the result of a mismatched show. A show named Anna was a 2022 show in sonarr but a different Anna (2021) in Plex.

Thanks for the feedback! I’ll close this issue. If you run into anything else, feel free to open a new issue / discussion.

from maintainerr.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.