Comments (5)
A stack trace is never desirable when a simple fix can be made.
You only get the stack trace if you have debug enabled. In normal use you get
But if you have a fix that is more helpful please submit a pull request with that code
from joomla-cms.
Hi Brian. Ah yes! I do have debug on and you are correct. It would still be preferable to enable the user to edit the menu item than to receive the error.
I've never submitted a pull request before, and I don't know if the fix I would suggest is acceptable, however it works for me (tested) by simply replacing the "throw new..." line I quoted above with "return;"
The thing I don't know is if there are ever any circumstances where one would desire the error message instead of silently ignoring the problem because I don't have enough in-depth knowledge of the code that may call it under other circumstances. It certainly fixes this specific scenario.
I shall see if I can submit the pull request. :-)
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43580.
from joomla-cms.
I think your fix is at the wrong place and would have to many side effects. Then main problem here is that the application can't load the form definition for the menu item. This is something you can't fix in a proper way. I think in such situations deleting the menu item and creating a new one would be the way to go.
from joomla-cms.
Please test #43604 as this should solve the issue at the com_menus level instead of globally on the Path class.
from joomla-cms.
closing as we have a pr #43604
from joomla-cms.
Related Issues (20)
- ModuleAdapter adds default settings to extension. Should be added to the created unpublished module
- No blank module for discover_install route HOT 5
- Error in microdata after updating to Joomla! 5.1.2 Stable HOT 9
- Joomla 4.4.6+ Hide Add module if not enough rights HOT 2
- Cassiopeia Colour Themes HOT 6
- [5.1.2] Using radio buttons with the "switcher" layout produces a JavaScript error in subforms HOT 3
- Add Development Container Configuration and GitHub Codespace Support HOT 3
- Tag field display wrong format in ajax mode and not respecting local mode attribute in search HOT 3
- Custom Fields | Display description in the admin HOT 6
- Tags | Batch function incomplete HOT 2
- [5.1] cli installation HOT 4
- linking to a contact HOT 2
- [5.1] Mfa::getConfigurationInterface thows error if called from other component. HOT 1
- Creating an article via Web Services doesn't provide a way of updating the Schema
- Timing Featuring an Article (Start featured) does not work HOT 1
- [5.1] EmailRule unique should look at input instead of form. HOT 3
- Lightbox (bootstrap.renderModal) doesn't correct work in 5.1.2 version
- Articles Ovewrites and Alternative Read more
- schemaorg entry isn't removed from #___schemaorg table when removing \ trashing an article.
- [5.1] Running a single test HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from joomla-cms.