Giter Club home page Giter Club logo

Comments (5)

brianteeman avatar brianteeman commented on July 24, 2024

A stack trace is never desirable when a simple fix can be made.

You only get the stack trace if you have debug enabled. In normal use you get

image

But if you have a fix that is more helpful please submit a pull request with that code

from joomla-cms.

bcraigie avatar bcraigie commented on July 24, 2024

Hi Brian. Ah yes! I do have debug on and you are correct. It would still be preferable to enable the user to edit the menu item than to receive the error.

I've never submitted a pull request before, and I don't know if the fix I would suggest is acceptable, however it works for me (tested) by simply replacing the "throw new..." line I quoted above with "return;"

The thing I don't know is if there are ever any circumstances where one would desire the error message instead of silently ignoring the problem because I don't have enough in-depth knowledge of the code that may call it under other circumstances. It certainly fixes this specific scenario.

I shall see if I can submit the pull request. :-)


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/43580.

from joomla-cms.

rdeutz avatar rdeutz commented on July 24, 2024

I think your fix is at the wrong place and would have to many side effects. Then main problem here is that the application can't load the form definition for the menu item. This is something you can't fix in a proper way. I think in such situations deleting the menu item and creating a new one would be the way to go.

from joomla-cms.

OctavianC avatar OctavianC commented on July 24, 2024

Please test #43604 as this should solve the issue at the com_menus level instead of globally on the Path class.

from joomla-cms.

alikon avatar alikon commented on July 24, 2024

closing as we have a pr #43604

from joomla-cms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.