Sometimes system test SiteMenuItems fails from API with 400 Bad Request about joomla-cms HOT 5 CLOSED

i was able to reproduce on 2nd run
": "Save failed with the following error: Joomla\\Component\\Menus\\Administrator\\Table\\MenuTable::_getNode(1, id) failed.",

and the #__menu table is messed up for lft, rgt

from joomla-cms.

• @alikon gave the correct hint there are problems with __menu table 👍
• the check of the table __menu shows that there is no entry with id 1 and therefore the used parent_id 1 fails, hardwired the parent_id was changed to (at this moment) existing id 2 the test run was successful several times
• a stable solution would therefore be to initial search for a (e.g. the first) menu item and then use this menu item ID as parent_id

from joomla-cms.

But the more important question is, why is the so importand looking __menu entry id=1 title=Menu_Item_Root alias=root deleted in a fresh instance with running only sytem tests? The obvious suspect is the test case can delete a site menu item in the same file. And with this question, the approach of getting the first menu entry and using its id sound more like a work around and does not fix the main cause that menu entry #1 being deleted.

from joomla-cms.

please test #43456

from joomla-cms.

on fresh macOS-docker-4.4-dev installation

• tested before the PR:
  • every run of SiteMenuItems.cy.js deletes one more entry from the __menu table, starting with id=1
  • from the 2nd run, the test case can create a site menu item fails because there is no longer a parent menu entry id=1
  • restored entry with:

INSERT INTO `jos44_menu` (`id`, `menutype`, `title`, `alias`, `note`, `path`, `link`, `type`, `published`, `parent_id`, `level`, `component_id`, `checked_out`, `checked_out_time`, `browserNav`, `access`, `img`, `template_style_id`, `params`, `lft`, `rgt`, `home`, `language`, `client_id`, `publish_up`, `publish_down`) VALUES
(1, '', 'Menu_Item_Root', 'root', '', '', '', '', 1, 0, 0, 0, NULL, NULL, 0, 0, '', 0, '', 0, 43, 0, '*', 0, NULL, NULL);

• applied gh pr checkout 43456
  • checked tests/System/integration/api/com_menus/SiteMenuItems.cy.js has changed to beforeEach
  • multiple runs of SiteMenuItems.cy.js
    • no test failures anymore ✅
    • no __menu entries are deleted ✅
  • overall test run with 110 specs and 435 test cases passed ✅

Thank you for fixing 😄

from joomla-cms.