Giter Club home page Giter Club logo

Comments (10)

brianteeman avatar brianteeman commented on May 30, 2024

Could not replicate using Joomla 5.1.0 rc1

tested on:

  • Chrome 123.0.6312.106 - Windows 11
  • Safari 17.3 on MacOS Sonoma
  • Firefox 124 on macOS Sonoma

from joomla-cms.

brianteeman avatar brianteeman commented on May 30, 2024

Correction.

I spotted after I had tested that your file was jpeg while I had tested with jpg

I can confirm errors with the exact same file after it has been renamed to jpeg

from joomla-cms.

exlemor avatar exlemor commented on May 30, 2024

Thank you @brianteeman - after your first message, I thought I was going mad for a second ;) lol

from joomla-cms.

brianteeman avatar brianteeman commented on May 30, 2024

could you just confirm that if you rename your image to jpg that there is no problem

from joomla-cms.

exlemor avatar exlemor commented on May 30, 2024

Actually better but not entirely perfect... IF I use the .jpg file [attached] from Pizza, Bugs & Fun 2024 from Paris.

Pizza-Bug-Fun-Paris-2024

I get the Save button to not give a Console error which seems a step in the right direction 🚀 but no visual indication/confirmation (like the green line loading in the URL in Safari to tell me it is updating the page etc) or message saying that the image was successfully saved. (only by going back to Media Manager do I know that the image is saved successfully or not).

BUT if I hit the Save button (and NOT seeing any screen indication of success), I then quickly hit Save & Close, I get this in Console:

3 TypeError: null is not an object (evaluating 'Joomla.MediaManager.Edit.xhr.readyState') in /media/com_media/js/edit-images.js?cf352a

(anonymous function) (edit-images.js:277)
N - async
(upload) (edit-images.js:171
(anonymous function) (edit-images.js:276)
(executeTask) (joomla-toolbar-button.js:120)

and nothing moves, i'm stuck not knowing what to do, if it worked etc if I then wait like 10-15 or so seconds and re-hit Save & Close, then it behaves as expected and goes back to the Media Manager with the image rotated as expected.

from joomla-cms.

brianteeman avatar brianteeman commented on May 30, 2024

similar problem reported by a user who had filename.JPG
resolved as soon as they changed it filename.jpg

from joomla-cms.

Quy avatar Quy commented on May 30, 2024

@exlemor Please test #43325 to see if it is a fix. Thanks.

from joomla-cms.

exlemor avatar exlemor commented on May 30, 2024

Hello @Quy, so yes it does fix my issue mostly.

It does now work for Cropping, Resizing, Rotating with a .JPG, .jpg, .jpeg, .Jpeg etc and that's wonderful

However, it still does NOT give a message of success when you press the Save button, as expressed above:
"BUT if I hit the Save button (and NOT seeing any screen indication of success)"

every other place in Joomla when you press the Save button gives you a message saying:

(success icon) Article saved.

or

(success icon) Field saved

etc

but here in the Media Manager --> Edit screen it seems someone forgot to connect the Save messages.

from joomla-cms.

Quy avatar Quy commented on May 30, 2024

Thanks for confirming the fix. Please see #35651 for a related issue.

from joomla-cms.

dgrammatiko avatar dgrammatiko commented on May 30, 2024

@Quy should #43325 be against 4.4.x, currently it's against 5.1?

from joomla-cms.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.