Banners application crashes about joomla-cms HOT 16 CLOSED

No worry @counterpoint . For the time being, you can make the propose change to your site to have the issue fixed. I will make the pull request on tomorrow to fix this issue so that it won't happen again when you update to future releases of Joomla

from joomla-cms.

I experience the same issue. When I publish a banner module or even access this page : administrator/index.php?option=com_banners&view=banners with Joomla installed on PHP 8.2.4, it crashes the website. Not only with Joomla 5, but I also experience the issue with Joomla 4.4.0.

from joomla-cms.

Sorry, forgot to mention that the file referred to that contains the error is .../administrator/components/com_banners/src/Helper/BannersHelper.php

from joomla-cms.

unable to replicate with php 8.2.16

from joomla-cms.

I cannot reproduce either. Please enable debug mode and set error reporting to maximum to get a stack trace.

from joomla-cms.

from my old memories could help
https://serverpilot.io/docs/error-failed-to-read-fastcgi-header/

from joomla-cms.

I have set the error reporting to maximum and enabled the debug mode, but no stack trace shows up. The issue disappeared when I commented out this line in mod_banners.php: BannersComponentHelper::updateReset();

from joomla-cms.

I cannot reproduce the issue, too. However, I can see that the code is wrong. @webchun @counterpoint Could you please modify this line of code https://github.com/joomla/joomla-cms/blob/4.4-dev/administrator/components/com_banners/src/Helper/BannersHelper.php#L42 to:

$date = Factory::getDate()->toSql();

Then check it again to see if the error is gon?

from joomla-cms.

from joomla-cms.

Debug and error reporting maximum were already enabled. But since the problem causes PHP to crash, diagnostics of that kind are not feasible. That made the problem difficult to track, since the only initial information was that there was a problem somewhere - probably in PHP code. PHP crashes may well be specific to a precise environnment. But Debian 12 is pretty mainstream. This link provides similar information to the link provided by @alikon but is not specific to Wordpress and indicates that a PHP error is the most common of the possible causes - https://bobcares.com/blog/apache-error-failed-to-read-fastcgi-header/

from joomla-cms.

@counterpoint You are right. I just checked the code more and see that (string) $date and $date->toSql() result in same value. However, I would use $date->toSql() to make it consistent with other places in Joomla. For example https://github.com/joomla/joomla-cms/blob/4.4-dev/components/com_content/src/Model/ArticleModel.php#L184 and https://github.com/joomla/joomla-cms/blob/4.4-dev/components/com_content/src/Model/ArticleModel.php#L202 (Who knows if we use a DB driver using a date format different with Y-m-d H:i:s)

Do you want to make PR with the suggested change?

from joomla-cms.

That makes sense @joomdonation, although (string) is a lot more efficient. What is PR?

from joomla-cms.

@counterpoint In short, you make code change to to fix the issue. Please try to follow instructions here https://docs.joomla.org/Using_the_Github_UI_to_Make_Pull_Requests to make the PR

The file you need to make change is https://github.com/joomla/joomla-cms/blob/4.4-dev/administrator/components/com_banners/src/Helper/BannersHelper.php (for 4.4-dev branch and later it will be up-merge to 5.1)

from joomla-cms.

Thanks @joomdonation. Sorry, but I'm not familiar with making git pull requests and do not have time to find out. I've precisely identified the fault, that should be enough.

from joomla-cms.

Thanks @joomdonation that's great.

from joomla-cms.

PR #42869 should address this issue. Please test it if you can. Thanks !

from joomla-cms.