Reflective Bean Converter and APT (ParamDefinition) have inconsistent Nullable/NonNull logic. about jooby HOT 5 CLOSED

hey the public account its @jknack... just realize I commented with my work account :D

from jooby.

@jknack @edgarespinawt let me know if you want me to put in a PR. I think its a pretty straight forward change so I didn't bother.

I made a big stink about ReflectiveBeanConverter on discord because I thought it was my fault (I too got mixed up with ParamDefinition and ReflectiveBeanConverter) and only found out about it being different when trying to convert Springs PetClinic to Jooby.

The ParamDefinition logic of checking Nullable I think is the ideal logic and I think will get us 90% there to handle most use cases.

Anyway feel free to task with me with something to make up for the confusion I caused.

from jooby.

yea, send a PR and we can move from there. Please don't use my other account.

from jooby.

Please don't use my other account.

So its @edgarespinawt going forward correct? (hopefully I don't ping you on the wrong one again :) )

Sorry about that. I wasn't clear if one of them was because of some sort of automation and you were accidentally logged in. Does this include handlebars.java as well?

from jooby.

Yeah kindly ask to try not to do that. The XZ thing has made my company and various others paranoid.

I'm guilty for pinging you on it as well. jknack for now on 😄

Also sorry for the discord overload of walls of paragraphs. I struggle with being pithy/concise.

from jooby.