Comments (5)
jonobr1
commented on May 23, 2024
You're right. It looks like SVG interprets this stuff differently: https://developer.mozilla.org/en-US/docs/Web/SVG/Attribute/dominant-baseline
Based on that document then it would map as follows:
| Two.js | SVG | |
|---|---|---|
| 1. | text.baseline = "top"; |
dominant-baseline="hanging" |
| 2. | text-baseline = "middle"; |
dominant-baseline="middle" |
| 3. | text-baseline = "bottom"; |
dominant-baseline="auto" |
from two.js.
dan-fritchman
commented on May 23, 2024
Thanks for jumping on this.
And agree that looks right. Particularly Mozilla’s featured example.
And I think I understand enough to get you an effective PR here. If you’ve got advice, preferences, or things to know, appreciate sharing.
from two.js.
jonobr1
commented on May 23, 2024
Oop, thanks for this but I beat you to it 😅
from two.js.
jonobr1
commented on May 23, 2024
This will be published on npm in the next week or so. I have a couple of other PRs that need tending to. Thanks for posting!
from two.js.
dan-fritchman
commented on May 23, 2024
Awesome thanks!
from two.js.
Related Issues (20)
- [Question] Woscope integration HOT 3
- How to animate millions of points on browser canvas using two.js HOT 12
- wrong type in getPointAT declaration in path class HOT 2
- "Dom-less" start for just generating result svg [Enhancement] HOT 1
- Can two handle thousands of svg path elements and hundreds of thousands of points? HOT 1
- [Enhancement] Add Path.Compound Static Method
- How to check if an object is currently being hovered by the mouse whilst taking rotation into account? HOT 3
- Two.Utils.read.path throws an error HOT 3
- Smooth out lines and Round Corners HOT 2
- [Bug] WebGL Renderer Blurry HOT 5
- Partial Ellipse HOT 6
- Text `BoundingClientRect` in nested groups HOT 2
- compile error typescript[Bug] HOT 2
- svg fill-opacity [Bug] HOT 12
- Issues with Zoom and ZUI when upgrading from version 8.1.1 to 8.11 (latest) HOT 3
- creating curve path using anchors and make path not working ! HOT 2
- [Question] Best way to render ~250k polygons HOT 6
- [Bug] Negative scale does not work, with webgl mode only HOT 1
- Can i add events to shapes if renderer is Two.CanvasRenderer HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from two.js.