Indexing `ComponentMatrix` with `FlatAxis` components about componentarrays.jl HOT 4 OPEN

I can actually fix this by commenting out this line, which creates a FlatAxis when constructing a ShapedAxis for a 1D array. That appears to preserve the necessary shape information that's needed by maybe_reshape. But that change breaks other things, unfortunately. For example, indexing a matrix with nested component axis like here no longer works, since the presence of the ShapedAxis triggers calling maybe_reshape, which can't figure out the necessary size of the nested component axis.

from componentarrays.jl.

OK, I attempted to fix this issue by introducing a Shaped1DAxis type in this PR: #249. It fixes the issue described here, but breaks some relatively minor things (IMHO). The most serious issue appears to be indexing a ComponentIndex with multiple symbols: https://github.com/dingraha/ComponentArrays.jl/blob/0db92aec69fac664524cc95a8f5fa1d3a605ce93/test/runtests.jl#L362, but that already didn't work with multi-dimensional ShapedAxis.

from componentarrays.jl.

Now almost everything works with #249. The things that are broken:

• Creating a ComponentArray with an empty NamedTuple is not identical to creating one with an empty Array, like this, as seen here:

ComponentArray(a = T[], b = (;)) == ComponentVector{T}(a = T[], b = T[])

• As mentioned above, indexing a ComponentIndex with multiple symbols doesn't work when one of the indices refers to a ShapedAxis, as seen here. IIUC that used to work when the index was one-dimensional (and was thus converted into a FlatAxis, but did not work for multi-dimensional ShapedAxis, and still doesn't.

from componentarrays.jl.

Managed to fix the test for indexing a ComponentIndex with multiple symbols. Now the only broken test in #249 is the "empty NamedTuple vs empty Array one, which is relatively minor IMHO.

from componentarrays.jl.