Not reading node_path about sublimejsprettier HOT 8 CLOSED

I really need to change (or add) the "node_path" variable name to read "prettier_path"... since the prettier executable resolves the path internally to node. Except for cases when installing prettier locally, in the Sublime Text Package directory.

@rawcreative: try changing the node_path in your user settings to the path where the prettier cli resides.

from sublimejsprettier.

Same result.. prettier is installed globally so it's in the same bin dir as node, i.e. the setting is the same. But it looks like it's just not even reading the settings file since it's saying that the node_path variable getting passed to isdir() is None, which is set here: https://github.com/jonlabelle/SublimeJsPrettier/blob/master/JsPrettier.py#L127

from sublimejsprettier.

After looking at the code again, I noticed that the node_path is never actually set if it's defined in the settings file, and even the defaults don't get set if node_path is set to anything other than false in the settings (the default is just an empty string). There are checks to see if it is defined, but it doesn't actually assign the defined value to the node_path variable. https://github.com/jonlabelle/SublimeJsPrettier/blob/master/JsPrettier.py#L138-L141

from sublimejsprettier.

@rawcreative: I just promoted v1.1.0. Let me know if this resolves your issue.

from sublimejsprettier.

Nope, while it looks like it's finding the prettier cli binary, for whatever reason it's throwing an env error that node cannot be found:

env: node: No such file or directory

from sublimejsprettier.

Closing. since it directly relates to #5... and #5 comes before #6.

from sublimejsprettier.

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

from sublimejsprettier.

See solution.

from sublimejsprettier.