Callback URL in BitBucket OAuth consumer about soba HOT 3 CLOSED

Hi, I've done some testing and found that it's not just a missing callback URL that causes an issue, but also if the following option isn't checked:

[ ] This is a private consumer
Enables the client_credentials grant type. Installable applications that ship their OAuth consumer credentials as part of the application should not be marked as private. 

The difference with BitBucket and the other providers is that BitBucket returns an HTTP 200 (Success) response when there's an auth failure response, so soba continued as if nothing was wrong.

I've modified a dependency jonhadfield/githosts-utils@f5981bc to ensure any errors are captured and returned.
...and put out a new release: https://github.com/jonhadfield/soba/releases/tag/1.2.7

Without callback uri defined:
soba: 2024/01/16 11:22:55 bitbucket.go:226: failed to get bitbucket auth token: invalid_request - No callback uri defined for the OAuth client.

Without setting OAuth consumer as a private consumer:
soba: 2024/01/16 11:22:27 bitbucket.go:226: failed to get bitbucket auth token: invalid_grant - Cannot use client_credentials with a consumer marked as "public". Calls for auto generated consumers should use urn:bitbucket:oauth2:jwt instead.

I'll put a note in the documentation also.

Thanks again for flagging, and let me know if you notice any issues.

from soba.

Hi, thanks for the feedback.
I'll take a look asap.

from soba.

thanks, works great!

from soba.