Giter Club home page Giter Club logo

Comments (7)

jonathangjertsen avatar jonathangjertsen commented on June 12, 2024

I'm not sure what you mean - the root note will be derived from the chord names in the string. The octave is chosen arbitrarily though - is that what you want to be able to specify?

Maybe you can provide some example code showing how you would like to use it?

from jchord.

flexiblestoic avatar flexiblestoic commented on June 12, 2024

Yes, I was thinking about the octave of the root note. I would use it like:

prog = ChordProgression.from_string("4F -- 3Am -- 4Dm7 -- 4F --")

Meaning the roots would be F4 A3 D4 and F4. The octave number before the note would be optional.

from jchord.

jonathangjertsen avatar jonathangjertsen commented on June 12, 2024

I see! Having the octave in front is a nice solution, I don't think it conflicts with any of the existing notation. It could probably be extended to solve #1 as well. I'll give it a go!

from jchord.

flexiblestoic avatar flexiblestoic commented on June 12, 2024

#1 Indeed. So the octave in front wouldn't the best solution to generalize. Maybe an optional dot notation?
The first inversion of C major starting on E4 would be E4.C
A C major starting on C5 would be C5.C

from jchord.

jonathangjertsen avatar jonathangjertsen commented on June 12, 2024

I've added support for the octave in front, available in version 1.0.0 (pip install jchord==1.0.0)

from jchord.

jonathangjertsen avatar jonathangjertsen commented on June 12, 2024

The first inversion of C major starting on E4 would be E4.C

If you just need to change the bass note, this is supported with slash chords, in this case you would write "5C/E". The "/E" adds an E below the root

from jchord.

flexiblestoic avatar flexiblestoic commented on June 12, 2024

Just tested. Works awesome. Thanks Jonathan!

from jchord.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.