[Feature] Allow defining labels for auto-created SSH Keys about docker-machine-driver-hetzner HOT 2 CLOSED

Sorry, seemed so easy, I just went ahead and did it. See my Pull request. :) Hope that works for you. Local testing seemed all fine, but I'm not successful in adding those labels via environment variables - but not for the server flags either. Maybe there's some special format required to pass on slices via env vars that I just don't know?

from docker-machine-driver-hetzner.

Hi,

thanks for the suggestion and for quickly implementing it yourself (I'm currently away from home without a machine properly set up for go development, so this would have taken me a bit presumably). I'll merge the PR after everything has passed.

Regarding your environment problem: Please see my comment on #37. Unfortunately environment variables for slice arguments are not being considered at all (EDIT: misremembered something here; the EnvVar setting is simply ignored). Unfortunately that's an issue of the underlying libmachine (for which development ceased with docker-machine IIRC), so I doubt we can easily fix that. As the driver is a separate binary communicating with the host docker-machine process via IPC simply switching to another arg parser is not really an option.

If you really do need to use environment variables, we either have to add another option with a non-slice type (perhaps key-label-list) and then split on ',' or something.

Sorry for the inconvenience.

from docker-machine-driver-hetzner.